openstack
/
cinder-specs
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review-1

(9 comments)

Patch-set: 4
Reviewer: Gerrit User 29122 <29122@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 4dcf1fa4e89edc8d3d151694a4088dc030f177ad
Attention: {"person_ident":"Gerrit User 20813 \u003c20813@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_29122\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9535 \u003c9535@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_29122\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 5314 \u003c5314@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_29122\u003e replied on the change"}
This commit is contained in:
Gerrit User 29122 2023-05-04 07:01:53 +00:00 committed by Gerrit Code Review
parent 89802a00d1
commit 9897798838
1 changed files with 201 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

201
d09f77bc62f7074bdb1f98094b56a1e1f3924a8c
View File

@ -1,5 +1,28 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "7758edf2_cdaad692",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 8,
"author": {
"id": 29122
},
"writtenOn": "2023-05-04T07:01:53Z",
"side": 1,
"message": "The first line should be limited to 50 characters.\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\nSuggestion: We can break first line into two lines:\nSpec Introduce new backup_status field for volume\n\nThis also involves split-up of the backup status away from\nthe volume_status",
"range": {
"startLine": 7,
"startChar": 0,
"endLine": 8,
"endChar": 42
},
"revId": "d09f77bc62f7074bdb1f98094b56a1e1f3924a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -33,6 +56,184 @@
"message": "Needs a detailed technical review as well",
"revId": "d09f77bc62f7074bdb1f98094b56a1e1f3924a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "539f07b4_cf3859bd",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 29122
},
"writtenOn": "2023-05-04T07:01:53Z",
"side": 1,
"message": "Minor typos inline",
"revId": "d09f77bc62f7074bdb1f98094b56a1e1f3924a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "71dbf02b_86765827",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 4
},
"lineNbr": 24,
"author": {
"id": 29122
},
"writtenOn": "2023-05-04T07:01:53Z",
"side": 1,
"message": "typo: synchronization",
"range": {
"startLine": 24,
"startChar": 50,
"endLine": 24,
"endChar": 65
},
"revId": "d09f77bc62f7074bdb1f98094b56a1e1f3924a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "08713760_6ca43ac4",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 4
},
"lineNbr": 40,
"author": {
"id": 29122
},
"writtenOn": "2023-05-04T07:01:53Z",
"side": 1,
"message": "nit: seems to be",
"range": {
"startLine": 40,
"startChar": 28,
"endLine": 40,
"endChar": 36
},
"revId": "d09f77bc62f7074bdb1f98094b56a1e1f3924a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "68055d82_bc5c2ad9",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 4
},
"lineNbr": 55,
"author": {
"id": 29122
},
"writtenOn": "2023-05-04T07:01:53Z",
"side": 1,
"message": "typo: maintenance",
"range": {
"startLine": 55,
"startChar": 9,
"endLine": 55,
"endChar": 21
},
"revId": "d09f77bc62f7074bdb1f98094b56a1e1f3924a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e1891574_23795f35",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 4
},
"lineNbr": 58,
"author": {
"id": 29122
},
"writtenOn": "2023-05-04T07:01:53Z",
"side": 1,
"message": "typo: indefinitely",
"range": {
"startLine": 58,
"startChar": 47,
"endLine": 58,
"endChar": 59
},
"revId": "d09f77bc62f7074bdb1f98094b56a1e1f3924a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4152d19f_9efeb21a",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 4
},
"lineNbr": 63,
"author": {
"id": 29122
},
"writtenOn": "2023-05-04T07:01:53Z",
"side": 1,
"message": "worsened",
"range": {
"startLine": 63,
"startChar": 14,
"endLine": 63,
"endChar": 21
},
"revId": "d09f77bc62f7074bdb1f98094b56a1e1f3924a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "08409af3_0230f88e",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 4
},
"lineNbr": 91,
"author": {
"id": 29122
},
"writtenOn": "2023-05-04T07:01:53Z",
"side": 1,
"message": "too",
"range": {
"startLine": 91,
"startChar": 47,
"endLine": 91,
"endChar": 49
},
"revId": "d09f77bc62f7074bdb1f98094b56a1e1f3924a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ab6509b3_6fd8ac71",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 4
},
"lineNbr": 262,
"author": {
"id": 29122
},
"writtenOn": "2023-05-04T07:01:53Z",
"side": 1,
"message": "field",
"range": {
"startLine": 262,
"startChar": 22,
"endLine": 262,
"endChar": 27
},
"revId": "d09f77bc62f7074bdb1f98094b56a1e1f3924a8c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}