Update patch set 6
Patch Set 6: Code-Review-1 (4 comments) Patch-set: 6 Reviewer: Gerrit User 597 <597@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 4b4a87aa4e570ae8d81688c15e0da65395dabf95 Attention: {"person_ident":"Gerrit User 32755 \u003c32755@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_597\u003e replied on the change"}
This commit is contained in:
parent
3bb52981c6
commit
ab2e79687e
|
@ -16,6 +16,86 @@
|
|||
"message": "Thank you very much for your intensive proof reading and review Brian and Rajat!\nI tried to use your feedback as best as I can to create a new revision.\n\nPlease kindly check out if you like the changes and please also let us get the last remaining discussions out of the way.",
|
||||
"revId": "96adb1c5d940aa84a5dfc566e26e3cb2e73a1013",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "865538c7_52eed3a6",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 597
|
||||
},
|
||||
"writtenOn": "2023-06-19T23:24:27Z",
|
||||
"side": 1,
|
||||
"message": "Overall this looks okay, but it omits one question: do we have any back-ends remaining that have no snapshot capability, and thus run backups straight from a volume?\n\nIf the question is yes, a compatibility strategy must be outlined. If the answer is no, the word \"most\" must be removed.\n\nI also added some less significant comments and questions.",
|
||||
"revId": "96adb1c5d940aa84a5dfc566e26e3cb2e73a1013",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d81b990f_478c59a4",
|
||||
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 36,
|
||||
"author": {
|
||||
"id": 597
|
||||
},
|
||||
"writtenOn": "2023-06-19T23:24:27Z",
|
||||
"side": 1,
|
||||
"message": "I understand from context that the task is waiting for the volume, but I don\u0027t know what \"happing\" is.",
|
||||
"range": {
|
||||
"startLine": 36,
|
||||
"startChar": 2,
|
||||
"endLine": 36,
|
||||
"endChar": 9
|
||||
},
|
||||
"revId": "96adb1c5d940aa84a5dfc566e26e3cb2e73a1013",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "78668ec9_e541b2f9",
|
||||
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 75,
|
||||
"author": {
|
||||
"id": 597
|
||||
},
|
||||
"writtenOn": "2023-06-19T23:24:27Z",
|
||||
"side": 1,
|
||||
"message": "And no \"idle\" state? The example below has:\n \"backup_status\": null\n\nPerhaps this needs to be touched upon. Under what conditions this is appropriate.",
|
||||
"range": {
|
||||
"startLine": 72,
|
||||
"startChar": 0,
|
||||
"endLine": 75,
|
||||
"endChar": 19
|
||||
},
|
||||
"revId": "96adb1c5d940aa84a5dfc566e26e3cb2e73a1013",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c499bf40_8ab7cd68",
|
||||
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 187,
|
||||
"author": {
|
||||
"id": 597
|
||||
},
|
||||
"writtenOn": "2023-06-19T23:24:27Z",
|
||||
"side": 1,
|
||||
"message": "Is something supposed to be here? Maybe \"not possible to update status or backup_status using `Update volume\u0027\"? If not, delete the empty clause.",
|
||||
"revId": "96adb1c5d940aa84a5dfc566e26e3cb2e73a1013",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue