openstack
/
cinder-specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(4 comments)

Patch-set: 5
Reviewer: Gerrit User 5314 <5314@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 2ae1f51bd083cbcb3bdf886f00a0b68d566ce04e
This commit is contained in:
Gerrit User 5314 2023-06-09 20:01:10 +00:00 committed by Gerrit Code Review
parent c3490c3add
commit b73dd8d759
1 changed files with 80 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

80
39b8be033e6eb2767022944faed5c1762647ef3b
View File

@ -68,6 +68,23 @@
"revId": "39b8be033e6eb2767022944faed5c1762647ef3b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "91d2d453_b0aa4712",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 5314
},
"writtenOn": "2023-06-09T20:01:10Z",
"side": 1,
"message": "Question inline.",
"revId": "39b8be033e6eb2767022944faed5c1762647ef3b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -292,6 +309,23 @@
"revId": "39b8be033e6eb2767022944faed5c1762647ef3b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d4d5250d_6ec3def0",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 5
},
"lineNbr": 85,
"author": {
"id": 5314
},
"writtenOn": "2023-06-09T20:01:10Z",
"side": 1,
"message": "Maybe I\u0027m not thinking of this the right way, but isn\u0027t there an asymmetry between backup and restore? What I mean is:\n\nbackup - basically, take a snapshot of the volume, then you should be able to do anything you want with the volume while the snapshot is being used to upload backup data to the backup backend\n\nrestore - by hypothesis, the volume data isn\u0027t available in the volume backend, so if I\u0027m restoring an 8TB backup, I can\u0027t really use the volume until the data is restored to it\n\nSo it doesn\u0027t seem like we can move all four values (backing-up, error_backing-up, restoring-backup, error_restoring) out of the volume_status and into the backup_status. For the restore case, I think we do need some kind of volume_status to indicate that the volume isn\u0027t ready yet.",
"revId": "39b8be033e6eb2767022944faed5c1762647ef3b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -361,6 +395,29 @@
"revId": "39b8be033e6eb2767022944faed5c1762647ef3b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1ad47af1_cdb67d25",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 5
},
"lineNbr": 145,
"author": {
"id": 5314
},
"writtenOn": "2023-06-09T20:01:10Z",
"side": 1,
"message": "Do you mean \u0027backup_status\u0027 here, or is your idea to keep the name general for possible expansion to other volume processes?",
"range": {
"startLine": 145,
"startChar": 34,
"endLine": 145,
"endChar": 45
},
"revId": "39b8be033e6eb2767022944faed5c1762647ef3b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -549,6 +606,29 @@
},
"revId": "39b8be033e6eb2767022944faed5c1762647ef3b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6f394fe1_3e52ec51",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 5
},
"lineNbr": 341,
"author": {
"id": 5314
},
"writtenOn": "2023-06-09T20:01:10Z",
"side": 1,
"message": "proposed",
"range": {
"startLine": 341,
"startChar": 15,
"endLine": 341,
"endChar": 24
},
"revId": "39b8be033e6eb2767022944faed5c1762647ef3b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}