openstack
/
cinder-specs
Code Issues Proposed changes

Update patch set 10 

Patch Set 10: Code-Review+2

(5 comments)

Patch-set: 10
Reviewer: Gerrit User 5314 <5314@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 6cfbf52ee8b56331655fbc30599ad3a9b21ac083
This commit is contained in:
Gerrit User 5314 2022-12-23 20:41:12 +00:00 committed by Gerrit Code Review
parent 690a21b179
commit b989538f49
1 changed files with 97 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

97
26d9c6bac09fb5535dd28fa1aa7506b6206d9b6a
View File

@ -16,6 +16,103 @@
"message": "All my comments are addressed and rendering also looks good. Thanks Konrad!\n\nhttps://20603c9ea2566663da21-42644bdefd5590a8f7e4e2e8a8a4112f.ssl.cf1.rackcdn.com/866718/10/check/openstack-tox-docs/76441da/docs/specs/2023.1/extend-volume-completion-action.html#id3",
"revId": "26d9c6bac09fb5535dd28fa1aa7506b6206d9b6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1532f211_b3a7b3b2",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 10
},
"lineNbr": 0,
"author": {
"id": 5314
},
"writtenOn": "2022-12-23T20:41:12Z",
"side": 1,
"message": "A few nits noted inline, but nothing to hold this up over. LGTM.",
"revId": "26d9c6bac09fb5535dd28fa1aa7506b6206d9b6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6fa8c52b_8818afe9",
"filename": "specs/2023.1/extend-volume-completion-action.rst",
"patchSetId": 10
},
"lineNbr": 67,
"author": {
"id": 5314
},
"writtenOn": "2022-12-23T20:41:12Z",
"side": 1,
"message": "This is kind of pessimistic ... why not have a ``success`` argument? 😊",
"range": {
"startLine": 67,
"startChar": 34,
"endLine": 67,
"endChar": 43
},
"revId": "26d9c6bac09fb5535dd28fa1aa7506b6206d9b6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bb3c7e80_cf65bf4c",
"filename": "specs/2023.1/extend-volume-completion-action.rst",
"patchSetId": 10
},
"lineNbr": 87,
"author": {
"id": 5314
},
"writtenOn": "2022-12-23T20:41:12Z",
"side": 1,
"message": "typo: volume\u0027s",
"range": {
"startLine": 87,
"startChar": 35,
"endLine": 87,
"endChar": 42
},
"revId": "26d9c6bac09fb5535dd28fa1aa7506b6206d9b6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2911d498_0c5ec9f7",
"filename": "specs/2023.1/extend-volume-completion-action.rst",
"patchSetId": 10
},
"lineNbr": 199,
"author": {
"id": 5314
},
"writtenOn": "2022-12-23T20:41:12Z",
"side": 1,
"message": "or any 5xxx code",
"revId": "26d9c6bac09fb5535dd28fa1aa7506b6206d9b6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4edad347_ce9808f8",
"filename": "specs/2023.1/extend-volume-completion-action.rst",
"patchSetId": 10
},
"lineNbr": 269,
"author": {
"id": 5314
},
"writtenOn": "2022-12-23T20:41:12Z",
"side": 1,
"message": "Thanks for this extended discussion of the alternatives.",
"revId": "26d9c6bac09fb5535dd28fa1aa7506b6206d9b6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}