diff --git a/acbd671fcd3471637898c6b9f4a256cc2c9727b5 b/acbd671fcd3471637898c6b9f4a256cc2c9727b5 new file mode 100644 index 00000000..e105aff6 --- /dev/null +++ b/acbd671fcd3471637898c6b9f4a256cc2c9727b5 @@ -0,0 +1,89 @@ +{ + "comments": [ + { + "unresolved": false, + "key": { + "uuid": "a32e8959_0d137ac8", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 1 + }, + "lineNbr": 0, + "author": { + "id": 27615 + }, + "writtenOn": "2024-04-11T14:11:50Z", + "side": 1, + "message": "some comments inline from a quick look", + "revId": "acbd671fcd3471637898c6b9f4a256cc2c9727b5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "3f91112a_9ddc1328", + "filename": "specs/2024.2/byok-for-cinder.rst", + "patchSetId": 1 + }, + "lineNbr": 49, + "author": { + "id": 27615 + }, + "writtenOn": "2024-04-11T14:11:50Z", + "side": 1, + "message": "maybe prefix a POST ?", + "revId": "acbd671fcd3471637898c6b9f4a256cc2c9727b5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "8ac56267_b1a4fb86", + "filename": "specs/2024.2/byok-for-cinder.rst", + "patchSetId": 1 + }, + "lineNbr": 50, + "author": { + "id": 27615 + }, + "writtenOn": "2024-04-11T14:11:50Z", + "side": 1, + "message": "can we also mention how the new parameter looks in the request body?", + "revId": "acbd671fcd3471637898c6b9f4a256cc2c9727b5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "4328eef8_13fc0c4b", + "filename": "specs/2024.2/byok-for-cinder.rst", + "patchSetId": 1 + }, + "lineNbr": 61, + "author": { + "id": 27615 + }, + "writtenOn": "2024-04-11T14:11:50Z", + "side": 1, + "message": "maybe mention here or somewhere that the passphrase used by user in barbican will not be able to decrypt the volume since cinder hexifies the barbican passphrase to encrypt the volume.", + "revId": "acbd671fcd3471637898c6b9f4a256cc2c9727b5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "7632bc51_f371890b", + "filename": "specs/2024.2/byok-for-cinder.rst", + "patchSetId": 1 + }, + "lineNbr": 76, + "author": { + "id": 27615 + }, + "writtenOn": "2024-04-11T14:11:50Z", + "side": 1, + "message": "need client support in OSC as well", + "revId": "acbd671fcd3471637898c6b9f4a256cc2c9727b5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file