openstack
/
cinder-specs
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 13425 <13425@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 006affdf4ced4530fb50902b2a888c0a4be7e8eb
Attention: {"person_ident":"Gerrit User 31779 \u003c31779@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_13425\u003e replied on the change"}
This commit is contained in:
Gerrit User 13425 2023-02-09 14:28:38 +00:00 committed by Gerrit Code Review
parent 7b609721b6
commit c58cb8dc2b
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
d614688d8b1c3c24235d131015cf269bd3dd833d Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "bb57d068_4d18f90d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 13425
},
"writtenOn": "2023-02-09T14:28:38Z",
"side": 1,
"message": "I thought the current PowerFlex driver could only create volumes that were rounded to 8Gb anyway:https://github.com/openstack/cinder/blob/393c2e4ad90c05ebf28cc3a2c65811d7e1e0bc18/cinder/volume/drivers/dell_emc/powerflex/options.py#L109\nso there currently is no way to create a 5GB volume and extend to 7GB as the inital 5GB creation would fail. This means that there is no need for this.\nPlus, I am only aware of PowerFlex having size rounding requirements, so this seems a lot of trouble in core code for one vendor specific \u0027feature\u0027.\n-1 so you can comment.",
"revId": "d614688d8b1c3c24235d131015cf269bd3dd833d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}