Update patch set 2

Patch Set 2: Code-Review-1

(15 comments)

Patch-set: 2
Reviewer: Gerrit User 13425 <13425@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, cc8e2755f9d111fff045c37af4b81103e4969ce7
This commit is contained in:
Gerrit User 13425 2024-02-22 14:13:31 +00:00 committed by Gerrit Code Review
parent ef0153cb50
commit fd70207f70
1 changed files with 343 additions and 0 deletions

View File

@ -0,0 +1,343 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "cc1df565_6741251b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "Some grammatical and spelling issues",
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "08cf5b8e_72d5dee0",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 26,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "this is part of the template and can be removed",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 26,
"endChar": 99
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9155277c_920b5444",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 51,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "nit: should",
"range": {
"startLine": 51,
"startChar": 36,
"endLine": 51,
"endChar": 42
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c484c4e3_10822ddb",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 56,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "nit: that",
"range": {
"startLine": 56,
"startChar": 0,
"endLine": 56,
"endChar": 6
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "98499fad_65c18f82",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 81,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "nit: someone",
"range": {
"startLine": 81,
"startChar": 67,
"endLine": 81,
"endChar": 72
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a193d0ad_ebab3d50",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 81,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "nit: becoming",
"range": {
"startLine": 81,
"startChar": 44,
"endLine": 81,
"endChar": 52
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "410882fa_22e830d5",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 124,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "nit: default",
"range": {
"startLine": 124,
"startChar": 34,
"endLine": 124,
"endChar": 42
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "00a6f9ff_875e9a11",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 131,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "nit: needs to be an",
"range": {
"startLine": 131,
"startChar": 40,
"endLine": 131,
"endChar": 56
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ee969ce5_35998256",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 140,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "nit: such as",
"range": {
"startLine": 140,
"startChar": 6,
"endLine": 140,
"endChar": 9
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "03fb7186_02fc57ed",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 159,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "nit: The latter",
"range": {
"startLine": 159,
"startChar": 65,
"endLine": 159,
"endChar": 72
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "57e13557_c0d9a30a",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 182,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "nit: unnecessary",
"range": {
"startLine": 182,
"startChar": 14,
"endLine": 182,
"endChar": 30
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1aad5979_fc2c09f7",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 183,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "nit: and",
"range": {
"startLine": 183,
"startChar": 11,
"endLine": 183,
"endChar": 15
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f3ff5c94_62b7ecc5",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 210,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "Remove",
"range": {
"startLine": 209,
"startChar": 0,
"endLine": 210,
"endChar": 46
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "489759b4_dd2286e8",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 273,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "Remove",
"range": {
"startLine": 271,
"startChar": 0,
"endLine": 273,
"endChar": 67
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "57e098ba_254a6684",
"filename": "specs/2024.1/user-visible-information-in-volume-types.rst",
"patchSetId": 2
},
"lineNbr": 277,
"author": {
"id": 13425
},
"writtenOn": "2024-02-22T14:13:31Z",
"side": 1,
"message": "nit: Cinder",
"range": {
"startLine": 277,
"startChar": 21,
"endLine": 277,
"endChar": 27
},
"revId": "59a8b7c422c86e6ef3fcd1df04fcf95ad959a649",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}