openstack
/
cinder-tempest-plugin
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review-1

(2 comments)

Patch-set: 7
Reviewer: Gerrit User 27615 <27615@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 7ab424e93cf7ee63e37af48a3d9641e7b56ca173
This commit is contained in:
Gerrit User 27615 2024-03-20 14:01:23 +00:00 committed by Gerrit Code Review
parent 6af6268a31
commit 51c3f41336
1 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
b42681daf98710688282a5295b88997ee664060a
View File

@ -33,6 +33,52 @@
"message": "run-NetApp CI",
"revId": "b42681daf98710688282a5295b88997ee664060a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5f257435_82681de3",
"filename": "cinder_tempest_plugin/rbac/v3/base.py",
"patchSetId": 7
},
"lineNbr": 124,
"author": {
"id": 27615
},
"writtenOn": "2024-03-20T14:01:23Z",
"side": 1,
"message": "I can\u0027t see this as a passed parameter",
"range": {
"startLine": 124,
"startChar": 12,
"endLine": 124,
"endChar": 44
},
"revId": "b42681daf98710688282a5295b88997ee664060a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "23c4140b_b1c4fa77",
"filename": "cinder_tempest_plugin/rbac/v3/base.py",
"patchSetId": 7
},
"lineNbr": 132,
"author": {
"id": 27615
},
"writtenOn": "2024-03-20T14:01:23Z",
"side": 1,
"message": "do you want to uncomment it or remove it?",
"range": {
"startLine": 132,
"startChar": 8,
"endLine": 132,
"endChar": 39
},
"revId": "b42681daf98710688282a5295b88997ee664060a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}