openstack
/
cinder-tempest-plugin
Code Issues Proposed changes

Update patch set 10 

Patch Set 10: Code-Review-1

(3 comments)

Patch-set: 10
Reviewer: Gerrit User 5314 <5314@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, bb07363e0d502652b7e500919a92585d4d0c1d92
This commit is contained in:
Gerrit User 5314 2024-04-26 14:09:44 +00:00 committed by Gerrit Code Review
parent 3bfb1cd234
commit 5cafb8d1b6
1 changed files with 57 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
ce01e35f1624586d2488ea9bb1b20dfd1e135c2c
View File

@ -16,6 +16,63 @@
"message": "recheck cinder-tempest-plugin-cbak-ceph - 39 failures, looks like mostly no valid host found when trying to create a server",
"revId": "ce01e35f1624586d2488ea9bb1b20dfd1e135c2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4d6284b7_1ba26c7c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 10
},
"lineNbr": 0,
"author": {
"id": 5314
},
"writtenOn": "2024-04-26T14:09:44Z",
"side": 1,
"message": "I think it would be helpful to structure these a bit differently. I think you\u0027ve been working on this issue so long that everything is obvious to you, but it\u0027s not so obvious to other contributors. See suggestions inline.",
"revId": "ce01e35f1624586d2488ea9bb1b20dfd1e135c2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "52809d72_0f30f5ae",
"filename": "cinder_tempest_plugin/api/volume/test_volume_dependency.py",
"patchSetId": 10
},
"lineNbr": 123,
"author": {
"id": 5314
},
"writtenOn": "2024-04-26T14:09:44Z",
"side": 1,
"message": "You will want to kill me, but I think these tests need to be in their own ImageVolumeDependencyTests class, because I think you need more tests. You can doc the class with something like, \"These tests should obviously pass when Glance and Cinder are using different backends. But when Glance and Cinder are configured to share a copy-on-write backend like Ceph, even though resources like images and volumes are independent at the openstack level, they will have relations in the backend that can prevent them from behaving normally with respect to deletion. This was particularly the case for RBD before change Ixxxxx.\"\n\nThen, I think add the tests in increasing order of insanity, like:\n\n1. create image, create volume, delete image\n2. create image, create volume1, clone volume2 from volume1, delete volume1, delete image\n3. add in snapshot stuff\n4. etc",
"revId": "ce01e35f1624586d2488ea9bb1b20dfd1e135c2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6bb786fa_f39cac2c",
"filename": "cinder_tempest_plugin/api/volume/test_volume_dependency.py",
"patchSetId": 10
},
"lineNbr": 135,
"author": {
"id": 5314
},
"writtenOn": "2024-04-26T14:09:44Z",
"side": 1,
"message": "You\u0027ll have to be careful how you phrase this, because conceptually the volume isn\u0027t cloned from the image (you don\u0027t want people to think you\u0027re testing the image-volume cache here, though probably that needs some more tests, too (but not necessarily in this patch)).",
"range": {
"startLine": 134,
"startChar": 34,
"endLine": 135,
"endChar": 15
},
"revId": "ce01e35f1624586d2488ea9bb1b20dfd1e135c2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}