openstack
/
cinder
Code Issues Proposed changes

VMware: set 'shared_targets' as False 

Commit 2fa6fdd784 added a flag
'shared_targets' to Volumes. This flag indicates whether or
not Nova should lock the attach/detach resource with the
'service_uuid'. In the case of the vmdk driver this is not needed
and results in degradation in performance.

Change-Id: I2eeaf96fdd66137f7bbe7a991e8ad07a49d209e1
This commit is contained in:
Gary Kotton 2018-07-22 03:44:08 -07:00
parent 06a30ceffd
commit 26413ec760
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cinder/tests/unit/volume/drivers/vmware/test_vmware_vmdk.py
View File

@ -117,6 +117,7 @@ class VMwareVcVmdkDriverTestCase(test.TestCase):
self.assertEqual(0, stats['reserved_percentage'])
self.assertEqual('unknown', stats['total_capacity_gb'])
self.assertEqual('unknown', stats['free_capacity_gb'])
self.assertFalse(stats['shared_targets'])
def _create_volume_dict(self,
vol_id=VOL_ID,

3
cinder/volume/drivers/vmware/vmdk.py
View File

@ -335,7 +335,8 @@ class VMwareVcVmdkDriver(driver.VolumeDriver):
'storage_protocol': 'vmdk',
'reserved_percentage': 0,
'total_capacity_gb': 'unknown',
'free_capacity_gb': 'unknown'}
'free_capacity_gb': 'unknown',
'shared_targets': False}
self._stats = data
return self._stats