From 157f6392a451b60781edb0d93169d6bc10803c48 Mon Sep 17 00:00:00 2001 From: Sean McGinnis Date: Fri, 31 Aug 2018 10:50:45 -0500 Subject: [PATCH] VMAX: set faked max_oversubscription_ratio FakeConfiguration is used in VMAX tests. Without a valueset for max_oversubscription_ratio, this results in test failures with the error: "TypeError: float() argument must be a string or a number, not 'NoneType'" This adds a default value for this config option in the fake config. Change-Id: Ia0b9772823fe9d093cfafe3ee241aad5b21fc3fd Signed-off-by: Sean McGinnis --- cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py | 1 + 1 file changed, 1 insertion(+) diff --git a/cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py b/cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py index 6f9779c95b0..abed0b350e9 100644 --- a/cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py +++ b/cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py @@ -1215,6 +1215,7 @@ class FakeConfiguration(object): self.volume_backend_name = volume_backend_name self.config_group = volume_backend_name self.san_is_local = False + self.max_over_subscription_ratio = 1 if replication_device: self.replication_device = [replication_device] for key, value in kwargs.items():