openstack
/
cinder
Code Issues Proposed changes

Add warning header to opts.py file 

The opts.py file should be generated by the the "tox -e genopts"
target. This adds a header to the file so someone unaware of this
is able to discover what is expected and not spend time trying
to make manual changes.

Change-Id: I96ffe08dbb15c30d00b817914247548732ac0f05
This commit is contained in:
Sean McGinnis 2017-06-05 13:00:44 -05:00
parent 1fbc072f77
commit a90727cf23
2 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
cinder/config/generate_cinder_opts.py
View File

@ -47,6 +47,18 @@ if __name__ == "__main__":
""")
opt_file.write(license_str)
edit_header = textwrap.dedent(
"""
###################################################################
# WARNING!
#
# Do not edit this file directly. This file should be generated by
# running the command "tox -e genopts" any time a config option
# has been added, changed, or removed.
###################################################################\n
""")
opt_file.write(edit_header)
opt_file.write("import itertools\n\n")
# NOTE(geguileo): We need to register all OVOs before importing any other

9
cinder/opts.py
View File

@ -12,6 +12,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.
###################################################################
# WARNING!
#
# Do not edit this file directly. This file should be generated by
# running the command "tox -e genopts" any time a config option
# has been added, changed, or removed.
###################################################################
import itertools
from cinder import objects