openstack
/
cinder
Code Issues Proposed changes

Merge "Add retry to LVM deactivation"

This commit is contained in:
Zuul 2018-08-29 22:07:05 +00:00 committed by Gerrit Code Review
parent b40251da0d 49f3c57d97
commit edfbe6fd43
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cinder/brick/local_dev/lvm.py
View File

@ -621,6 +621,7 @@ class LVM(executor.Executor):
return True
return False
@utils.retry(exception.VolumeNotDeactivated, retries=1, interval=2)
def deactivate_lv(self, name):
lv_path = self.vg_name + '/' + self._mangle_lv_name(name)
cmd = ['lvchange', '-a', 'n']
@ -630,7 +631,7 @@ class LVM(executor.Executor):
root_helper=self._root_helper,
run_as_root=True)
except putils.ProcessExecutionError as err:
LOG.exception('Error deactivating LV')
LOG.exception('Error deactivating LV, retry may be possible')
LOG.error('Cmd :%s', err.cmd)
LOG.error('StdOut :%s', err.stdout)
LOG.error('StdErr :%s', err.stderr)