openstack
/
cinder
Code Issues Proposed changes
OpenStack Block Storage (Cinder)
4,416 Commits 9 Branches 67 Tags 886 MiB
Python 99.7%
Smarty 0.3%
Go to file
git-harry 322126212e Fix calls to assert_called_once in unit tests 
Mock has a method called assert_called_once_with to check that a mock
was called and the arguments it took were as expected. Mock does not
have a method called assert_called_once and calling it just creates a
mock bound to that name. This means that not only is nothing tested
when assert_called_once is used, the tests also don't warn about this.

This commit attempts to address this in two ways:
    - all occurrences of assert_called_once are replaced with a real
      assertion.
    - the hacking check that nova uses to guard against this has been
      copied to cinder's local hacking checks.

Fixing the assert_called_once issues also highlighted other mistakes
in certain tests which were addressed to make the tests pass.

Due to the nature of mock, this issue is also possible if a method is
misspelt or just mistakenly used and so the hacking check is only
addressing one very specific case. That said, it does appear to be a
common mistake and so is worth singling out.

Change-Id: Iedcc3f48d91f7ebd8878ccc3bca3d023503774bd
Closes-Bug: #1394544
 		2014-11-24 16:56:10 +00:00
bin Merge "Implementing the use of _L’x’/i18n markers" 2014-11-04 10:38:10 +00:00
cinder Fix calls to assert_called_once in unit tests 2014-11-24 16:56:10 +00:00
doc Update prerequisite packages in development docs 2014-11-19 23:09:36 +00:00
etc/cinder Merge "Sync policy from oslo-incubator" 2014-11-24 00:08:21 +00:00
rally-scenarios Add rally job 2014-04-25 18:31:06 +03:00
tools Ignore pylint error 'hashlib' has no shaxxx member 2014-08-29 12:18:06 -04:00
.coveragerc Add .coveragerc to show proper coverage statistics. As in other openstack projects. 2013-05-15 03:40:07 -07:00
.gitignore gitignore /.* 2014-10-09 15:23:48 -04:00
.gitreview Initial fork out of Nova. 2012-05-03 10:48:26 -07:00
.mailmap Add mailmap entry 2014-05-07 12:03:15 -07:00
.testr.conf Fix up the test framework 2013-06-14 14:02:17 +00:00
CONTRIBUTING.md Fix the section name in CONTRIBUTING.rst 2014-07-14 19:53:30 +08:00
HACKING.rst Fix calls to assert_called_once in unit tests 2014-11-24 16:56:10 +00:00
LICENSE Initial fork out of Nova. 2012-05-03 10:48:26 -07:00
MANIFEST.in Use setuptools-git. 2012-08-10 11:56:00 -04:00
README.rst Adding helpful URL links to README.rst and HACKING.rst 2013-12-27 19:29:17 -06:00
babel.cfg Initial fork out of Nova. 2012-05-03 10:48:26 -07:00
openstack-common.conf Remove module timeutils 2014-11-24 13:54:23 +08:00
pylintrc Amend unused variables to assist pylint testing 2014-10-30 16:23:57 +00:00
requirements.txt Updated from global requirements 2014-11-23 09:34:17 +00:00
run_tests.sh Fix running unit tests with coverage 2014-09-02 13:04:06 +01:00
setup.cfg Open Kilo development 2014-09-30 09:25:35 +02:00
setup.py Updated from global requirements 2014-05-22 07:04:39 +00:00
test-requirements.txt Updated from global requirements 2014-11-23 09:34:17 +00:00
tox.ini Activate pep8 check that _ is imported 2014-10-30 21:28:41 +00:00

README.rst

The Choose Your Own Adventure README for Cinder

You have come across a storage service for an open cloud computing service. It has identified itself as "Cinder." It was abstracted from the Nova project.

To monitor it from a distance: follow @openstack on twitter.

To tame it for use in your own cloud: read http://docs.openstack.org

To study its anatomy: read http://cinder.openstack.org

To dissect it in detail: visit http://github.com/openstack/cinder

To taunt it with its weaknesses: use http://bugs.launchpad.net/cinder

To watch it: http://jenkins.openstack.org

To hack at it: read HACKING.rst