937af5be0e
When glanceclient raises an IOError with a different errno than ENOSPC, cinder-volume silently masked it and continued its volume creation process. The result was volumes with invalid content being successfuly created. With the patch, an ImageDownloadFailed exception is raised in this case, which makes the volume creation process fail and gives enough information to operators for troubleshooting. As explained in detail below, this patch is a squash of four cherry picks to fix Bug #1799221. The cherry-picks are being squashed instead of done separately per normal cinder practice because they are dependent; this will make sure that one of them isn't further backported without the supporting patches. Here's the relationship between the four cherry-picks: (1) The purpose of this backport is to fix Bug #1799221, which was introduced in Pike. It is fixed in Stein and Rocky by Ic011fe30b4840e5098db1a594ea276ec98768bff (2) That change requires an exception introduced in Stein and backported to Rocky by If7c22ac4516f8c2a6ccd8bf6b6ed98409312b138 to fix Bug #1798147 (which defect is also present in Queens and Pike) (3) The change in (2) introduced Bug #1808443 which was fixed in Stein and Rocky by I6d8dedfd056add3414f8f4bf7f7279eae4763286 (4) The change in (2) also introduced Bug #1811184, which is fixed by I6d8dedfd056add3414f8f4bf7f7279eae4763286 in Stein and Rocky, and which adds a unit test for Bug #1798147. In short, in order to backport the fix for (1), we need to backport (2), but in order to backport (2) we need to follow up immediately with backports of (3) and (4) to fix the defects (2) introduces. The attentive reader will note that this patch smuggles in the fix for Bug #1798147. We could have left this out, but it's a very small isolated change, the defect is present in Queens and Pike (remember that Bug #1799221, the subject of this patch, was introduced in Pike), and it has a unit test (see (4), above). Finally, leaving out the fix for Bug #1798147 and backporting only the exception would still require backporting the fixes for Bug #1808443 and Bug #1811184, so it really would not simplify this patch. To summarize what's being included here: commit changeId fixed bug |
||
|---|---|---|
| .. | ||
| notes | ||
| source | ||
| README.rst | ||
README.rst
Release notes
The release notes for a patch should be included in the patch. The intended audience for release notes include deployers, administrators and end-users.
A release note is required if the patch has upgrade or API impact. It is also required if the patch adds a feature or fixes a long-standing or security bug.
Please see https://docs.openstack.org/cinder/latest/contributor/releasenotes.html for more details.