openstack
/
cinderlib
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
This commit is contained in:
Gerrit User 5314 2024-01-05 14:34:41 +00:00 committed by Gerrit Code Review
parent 8747c94937
commit 525eda940b
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
6b5d5fef584c10bf8e5754800a2f8b8d956bb950
View File

@ -98,6 +98,23 @@
"message": "recheck - dependency has merged",
"revId": "6b5d5fef584c10bf8e5754800a2f8b8d956bb950",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bbcdfcea_c8ddb3c8",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 5314
},
"writtenOn": "2024-01-05T14:34:41Z",
"side": 1,
"message": "@Tony\n\n\u003e major tangent but the preferred format of Depends-On, is change URLs rather than Change-Id\n\nCould you explain this? I tend to use a URL (didn\u0027t in this case because I prepared this series of patches offline before submitting to gerrit, and didn\u0027t have the URLs yet). Some people I work with (though not on the infra team) insist that the Change-Id is better, and I\u0027d like to be able to say why URLs are preferred.",
"revId": "6b5d5fef584c10bf8e5754800a2f8b8d956bb950",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}