From 02e89274e25984b2ae143d9c9eca5308b3cc180e Mon Sep 17 00:00:00 2001 From: lingyongxu Date: Tue, 18 Jul 2017 14:51:22 +0800 Subject: [PATCH] Use assertIsNone(...) instead of assertIs(None,...) Following OpenStack Style Guidelines: [1] Unit test assertions tend to give better messages for more specific assertions. As a result, assertIsNone(...) is preferred over assertIs(None, ...) [1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises Change-Id: Ie4ee3be201f799d87c06378cd2c9a0a3c34c24df --- cliff/tests/test_app.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cliff/tests/test_app.py b/cliff/tests/test_app.py index 4430d772..e26e4f75 100644 --- a/cliff/tests/test_app.py +++ b/cliff/tests/test_app.py @@ -73,9 +73,9 @@ class TestInteractiveMode(base.TestBase): app.interactive_app_factory = mock.MagicMock( name='interactive_app_factory' ) - self.assertIs(None, app.interpreter) + self.assertIsNone(app.interpreter) app.run([]) - self.assertIsNot(None, app.interpreter) + self.assertIsNotNone(app.interpreter) cmdloop = app.interactive_app_factory.return_value.cmdloop cmdloop.assert_called_once_with()