Add success and error messages on some forms

On some forms, after the operation succeeds or fails,
no prompt message is displayed.

This patch add success and error messages on some forms

Change-Id: Ibf031845dd4d30221f45b7501342c22a0c3ccd79
This commit is contained in:
pengyuesheng 2019-06-10 10:18:13 +08:00
parent a82f7cfa16
commit 958202bd4f
3 changed files with 44 additions and 10 deletions

View File

@ -15,7 +15,9 @@ from decimal import Decimal
import logging
from django.utils.translation import ugettext_lazy as _
from horizon import exceptions as horizon_exceptions
from horizon import forms
from horizon import messages
from keystoneauth1 import exceptions
from cloudkittydashboard.api import cloudkitty as api
@ -61,7 +63,15 @@ class CreateServiceForm(forms.SelfHandlingForm):
service = data['custom_service']
services_mgr = api.cloudkittyclient(request).rating.hashmap
LOG.info('Creating service with name %s' % (service))
return services_mgr.create_service(name=service)
try:
service = services_mgr.create_service(name=service)
messages.success(
request,
_('Service was successfully created'))
return service
except Exception:
horizon_exceptions.handle(request,
_("Unable to create new service."))
def __init__(self, request, *args, **kwargs):
super(CreateServiceForm, self).__init__(request, *args, **kwargs)

View File

@ -13,7 +13,9 @@
# under the License.
from django.utils.translation import ugettext_lazy as _
from horizon import exceptions
from horizon import forms
from horizon import messages
from cloudkittydashboard.api import cloudkitty as api
@ -23,7 +25,12 @@ class EditPriorityForm(forms.SelfHandlingForm):
def handle(self, request, data):
ck_client = api.cloudkittyclient(request)
return ck_client.rating.update_module(
module_id=self.initial["module_id"],
priority=data["priority"]
)
try:
priority = ck_client.rating.update_module(
module_id=self.initial["module_id"], priority=data["priority"])
messages.success(
request,
_('Successfully updated priority'))
return priority
except Exception:
exceptions.handle(request, _("Unable to update priority."))

View File

@ -16,7 +16,9 @@ import logging
from django.utils.text import normalize_newlines
from django.utils.translation import ugettext_lazy as _
from horizon import exceptions
from horizon import forms
from horizon import messages
from cloudkittydashboard.api import cloudkitty as api
@ -92,9 +94,16 @@ class CreateScriptForm(forms.SelfHandlingForm):
name = data['name']
LOG.info('Creating script with name %s' % (name))
ck_client = api.cloudkittyclient(request)
return ck_client.rating.pyscripts.create_script(
name=name,
data=data['script_data'])
try:
script = ck_client.rating.pyscripts.create_script(
name=name,
data=data['script_data'])
messages.success(
request,
_('Successfully created script'))
return script
except Exception:
exceptions.handle(request, _("Unable to create script."))
class EditScriptForm(CreateScriptForm):
@ -111,5 +120,13 @@ class EditScriptForm(CreateScriptForm):
script_id = self.initial['script_id']
LOG.info('Updating script with id %s' % (script_id))
ck_client = api.cloudkittyclient(request)
return ck_client.rating.pyscripts.update_script(
script_id=script_id, name=data['name'], data=data['script_data'])
try:
script = ck_client.rating.pyscripts.update_script(
script_id=script_id, name=data['name'],
data=data['script_data'])
messages.success(
request,
_('Successfully updated script'))
return script
except Exception:
exceptions.handle(request, _("Unable to update script."))