From 8a2d28c06897948c190cb6327ccb56cca0aa88e9 Mon Sep 17 00:00:00 2001 From: Lucian Petrut Date: Tue, 14 Nov 2017 14:05:19 +0200 Subject: [PATCH] [Trivial] raise log level to error, as per TODO We have some important error messages logged at debug level. The reason is that those were introduced during string freeze and at that point, error messages were always translated. This change raises the according log level to "error", as per the TODO inline comments. Change-Id: I4c6909edb24d8fc5d7fe07f95bd4a7f09b853c4b --- compute_hyperv/nova/vmops.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/compute_hyperv/nova/vmops.py b/compute_hyperv/nova/vmops.py index 940e3570..ebf47ce8 100644 --- a/compute_hyperv/nova/vmops.py +++ b/compute_hyperv/nova/vmops.py @@ -1063,15 +1063,13 @@ class VMOps(object): return True if not self._hostutils.check_min_windows_version(10, 0): - # TODO(claudiub): add set log level to error after string freeze. - LOG.debug("vNIC hot plugging is supported only in newer " + LOG.error("vNIC hot plugging is supported only in newer " "versions than Windows Hyper-V / Server 2012 R2.") return False if (self._vmutils.get_vm_generation(instance.name) == constants.VM_GEN_1): - # TODO(claudiub): add set log level to error after string freeze. - LOG.debug("Cannot hot plug vNIC to a first generation VM.", + LOG.error("Cannot hot plug vNIC to a first generation VM.", instance=instance) return False @@ -1097,8 +1095,7 @@ class VMOps(object): self._vif_driver.unplug(instance, vif) self._vmutils.destroy_nic(instance.name, vif['id']) except os_win_exc.HyperVVMNotFoundException: - # TODO(claudiub): add set log level to error after string freeze. - LOG.debug("Instance not found during detach interface. It " + LOG.error("Instance not found during detach interface. It " "might have been destroyed beforehand.", instance=instance) raise exception.InterfaceDetachFailed(instance_uuid=instance.uuid)