From cd1c3474acf659f3d2426917541ed4526515c1f9 Mon Sep 17 00:00:00 2001 From: chao liu Date: Mon, 29 Jan 2018 05:23:52 -0800 Subject: [PATCH] use . instead of source. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Code conventions: Use “.” to source script files When you have to source a script file, for example , a credentials file to gain access to user-only or admin-only CLI commands, use . instead of source. See more: http://docs.openstack.org/contributor-guide/writing-style/code-conventions Change-Id: I1788a2e5f1d9e067e2411bb159316ca7990fe46f --- examples/cfg_validator/deploy.sh | 2 +- examples/murano/predeploy_simulate.sh | 4 ++-- scripts/manual_testing/doctor_pushdriver.sh | 2 +- scripts/manual_testing/general.sh | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/cfg_validator/deploy.sh b/examples/cfg_validator/deploy.sh index 02b636dcb..89c67170a 100755 --- a/examples/cfg_validator/deploy.sh +++ b/examples/cfg_validator/deploy.sh @@ -6,7 +6,7 @@ DIR="$(cd $(dirname "$0") && pwd)" RULES_DIR="${DIR}/rules" cd /opt/stack/congress -source ~/devstack/openrc admin admin +. ~/devstack/openrc admin admin echo echo "Creating datasource config" diff --git a/examples/murano/predeploy_simulate.sh b/examples/murano/predeploy_simulate.sh index b95539eb7..c55c1bd3d 100755 --- a/examples/murano/predeploy_simulate.sh +++ b/examples/murano/predeploy_simulate.sh @@ -1,5 +1,5 @@ cd /opt/stack/congress -source ~/devstack/openrc admin demo +. ~/devstack/openrc admin demo echo "Creating datasource murano: user=admin, tenant=demo" openstack congress datasource create murano "murano" \ @@ -108,4 +108,4 @@ openstack congress policy simulate murano_system 'predeploy_error(env_id)' ' murano:parent_types+("instance_uuid", "io.murano.Object") murano:parent_types+("instance_uuid", "instance_type") - murano:properties+("instance_uuid", "flavor", "m1.large")' action \ No newline at end of file + murano:properties+("instance_uuid", "flavor", "m1.large")' action diff --git a/scripts/manual_testing/doctor_pushdriver.sh b/scripts/manual_testing/doctor_pushdriver.sh index 9c7057839..5e9f76f1e 100755 --- a/scripts/manual_testing/doctor_pushdriver.sh +++ b/scripts/manual_testing/doctor_pushdriver.sh @@ -7,7 +7,7 @@ # The following OpenStack environment variables must set first: # OS_USERNAME, OS_PASSWORD, OS_PROJECT_NAME, OS_TENANT_NAME, OS_AUTH_URL # For example by running (under a devstack setup) -# $ source devstack/openrc admin admin +# $ . devstack/openrc admin admin ############################################################################# UUID=`openstack congress datasource create doctor doctor -f value | sed -n '5p'` diff --git a/scripts/manual_testing/general.sh b/scripts/manual_testing/general.sh index 8572ee951..4a644ae14 100755 --- a/scripts/manual_testing/general.sh +++ b/scripts/manual_testing/general.sh @@ -8,7 +8,7 @@ # The following OpenStack environment variables must set first: # OS_USERNAME, OS_PASSWORD, OS_PROJECT_NAME, OS_TENANT_NAME, OS_AUTH_URL # For example by running (under a devstack setup) -# $ source devstack/openrc admin admin +# $ . devstack/openrc admin admin ############################################################################# openstack congress version list