openstack
/
congress
Code Issues Proposed changes

Wrapper for updating Neutron resources 

This wrapper enables updating of Neutron resources with arbitrary
resource attributes. A minimum of 1 Neutron resource attribute
(key-value) has to be updated.

Example:

  execute[neutronv2:update_resource_attrs("port",
              "25443f00-1ef4-47fd-b1fa-f494126e196e",
              "admin_state_up", "False")]

Implements: blueprint update-neutron-resources
Change-Id: If382f28f7dc377e4d5d6267fd7f459f1156e975d
This commit is contained in:
Carlos Goncalves 2017-02-07 10:39:32 +00:00
parent 54926c4411
commit daca060c30
2 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
congress/datasources/neutronv2_driver.py
View File

@ -337,6 +337,23 @@ class NeutronV2Driver(datasource_driver.PollingDataSourceDriver,
self.creds = args
session = ds_utils.get_keystone_session(self.creds)
self.neutron = neutronclient.v2_0.client.Client(session=session)
self.add_executable_method('update_resource_attrs',
[{'name': 'resource_type',
'description': 'resource type (e.g. ' +
'port, network, subnet)'},
{'name': 'id',
'description': 'ID of the resource'},
{'name': 'attr1',
'description': 'attribute name to ' +
'update (e.g. admin_state_up)'},
{'name': 'attr1-value',
'description': 'updated attr1 value'},
{'name': 'attrN',
'description': 'attribute name to ' +
'update'},
{'name': 'attrN-value',
'description': 'updated attrN value'}],
"A wrapper for update_<resource_type>()")
self.add_executable_client_methods(self.neutron,
'neutronclient.v2_0.client')
self.initialize_update_methods()
@ -431,3 +448,21 @@ class NeutronV2Driver(datasource_driver.PollingDataSourceDriver,
func(action_args)
else:
self._execute_api(self.neutron, action, action_args)
def update_resource_attrs(self, args):
positional_args = args.get('positional', [])
if not positional_args or len(positional_args) < 4:
LOG.error('Args for update_resource_attrs() must contain resource '
'type, resource ID and pairs of key-value attributes to '
'update')
return
resource_type = positional_args.pop(0)
resource_id = positional_args.pop(0)
action = 'update_%s' % resource_type
update_attrs = self._convert_args(positional_args)
body = {resource_type: update_attrs}
action_args = {'named': {resource_type: resource_id,
'body': body}}
self._execute_api(self.neutron, action, action_args)

9
congress/tests/datasources/test_neutronv2_driver.py
View File

@ -483,3 +483,12 @@ class TestNeutronV2Driver(base.TestCase):
self.driver.execute('connectNetwork', api_args)
self.assertEqual(expected_ans, neutron_client.testkey)
def test_update_resource_attrs(self):
args = {'positional': ['port', '1', 'key1', 'val1']}
action_args = {'named': {'port': '1',
'body': {'port': {'key1': 'val1'}}}}
with mock.patch.object(self.driver, '_execute_api') as mock_ea:
self.driver.update_resource_attrs(args)
mock_ea.assert_called_with(self.driver.neutron, 'update_port',
action_args)