openstack
/
cyborg
Code Issues Proposed changes

fix function usage errors 

When comparing variables, should use assertEqual

Related-Bug: #2002460

Change-Id: I59c6910666a0f75934162126dd35883dc32449dc
This commit is contained in:
zhangtongjian 2023-01-11 18:44:23 +08:00
parent 9761e1aa0c
commit 99858d03b8
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cyborg/tests/unit/api/controllers/v2/test_attributes.py
View File

@ -70,7 +70,7 @@ class TestAttributes(v2_test.APITestV2):
url = self.ATTRIBUTE_URL + "?deployable_id=" + str(deployable_id)
out_attributes = self.get_json(url, headers=self.headers)
mock_deployable_id.assert_called_once()
self.assertTrue(len(out_attributes), len(attributes))
self.assertEqual(len(out_attributes), len(attributes))
@mock.patch('cyborg.objects.Attribute.get_by_filter')
def test_get_all(self, mock_attributes):
@ -78,7 +78,7 @@ class TestAttributes(v2_test.APITestV2):
data = self.get_json(self.ATTRIBUTE_URL, headers=self.headers)
out_attributes = data['attributes']
self.assertIsInstance(out_attributes, list)
self.assertTrue(len(out_attributes), len(self.fake_attribute_objs))
self.assertEqual(len(out_attributes), len(self.fake_attribute_objs))
for in_attribute, out_attribute in zip(self.fake_attribute_objs,
out_attributes):
self._validate_attributes(in_attribute, out_attribute)
@ -90,7 +90,7 @@ class TestAttributes(v2_test.APITestV2):
url = self.ATTRIBUTE_URL + "?key=" + attributes[0]['key']
out_attributes = self.get_json(url, headers=self.headers)
mock_key.assert_called_once()
self.assertTrue(len(out_attributes), len(attributes))
self.assertEqual(len(out_attributes), len(attributes))
@mock.patch('cyborg.objects.Attribute.create')
def test_create(self, mock_cond_attribute):
@ -110,7 +110,7 @@ class TestAttributes(v2_test.APITestV2):
data = self.get_json(url, headers=self.headers)
out_attributes = data['attributes']
mock_attribute.assert_called_once()
self.assertTrue(len(out_attributes), len(attributes))
self.assertEqual(len(out_attributes), len(attributes))
for in_attribute, out_attribute in zip(attributes, out_attributes):
self._validate_attributes(in_attribute, out_attribute)