From b360565c49a12e34f89838147fe00bfdf9786b71 Mon Sep 17 00:00:00 2001 From: Dongcan Ye Date: Tue, 6 Jun 2017 11:57:20 +0800 Subject: [PATCH] Refactor find iptables rules Using list comprehension instead of for loop, it's good for readability. TrivialFix Change-Id: Ieb003a615111738687a17c7d056a536c21c32f6e --- .../services/firewall/drivers/linux/iptables_fwaas.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/neutron_fwaas/services/firewall/drivers/linux/iptables_fwaas.py b/neutron_fwaas/services/firewall/drivers/linux/iptables_fwaas.py index 067d39801..f7b642d39 100644 --- a/neutron_fwaas/services/firewall/drivers/linux/iptables_fwaas.py +++ b/neutron_fwaas/services/firewall/drivers/linux/iptables_fwaas.py @@ -266,15 +266,11 @@ class IptablesFwaasDriver(fwaas_base.FwaasDriverBase): return changed_rules def _find_removed_rules(self, pre_firewall, firewall): - removed_rules = [] fw_rules_list = firewall[f_const.FIREWALL_RULE_LIST] pre_fw_rules_list = pre_firewall[f_const.FIREWALL_RULE_LIST] - fw_rule_ids = [] - for fw_rule in fw_rules_list: - fw_rule_ids.append(fw_rule.get('id')) - for pre_fw_rule in pre_fw_rules_list: - if pre_fw_rule.get('id') not in fw_rule_ids: - removed_rules.append(pre_fw_rule) + fw_rule_ids = [fw_rule.get('id') for fw_rule in fw_rules_list] + removed_rules = [pre_fw_rule for pre_fw_rule in + pre_fw_rules_list if pre_fw_rule.get('id') not in fw_rule_ids] return removed_rules def _find_new_rules(self, pre_firewall, firewall):