openstack
/
deb-python-cinderclient
Code Issues Proposed changes

Fix PY2/PY3 specific error in testcases 

The behaviour of PY3's standard lib 'argparse'
differs from PY2's.

```
cinder extend 2
usage: cinder extend <volume> <new_size>
error: too few arguments
Try 'cinder help extend' for more information.

cinder extend 3
usage: cinder extend <volume> <new_size>
error: the following arguments are required: <new_size>
Try 'cinder help extend' for more information.

```
This could lead to the partly failure of functional testcase,
fix it.

Change-Id: I59e9ae149af0b4294b09a94a52a4bc86a1d90f2b
Closes-Bug: #1697428
This commit is contained in:
TommyLike 2017-06-12 19:49:47 +08:00
parent 44e650a4ed
commit 1a5910cbd8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinderclient/tests/functional/test_volume_extend_cli.py
View File

@ -27,7 +27,7 @@ class CinderVolumeExtendNegativeTests(base.ClientTestBase):
self.volume = self.object_create('volume', params='1')
@ddt.data(
('', (r'too few arguments')),
('', (r'too few arguments|the following arguments are required')),
('-1', (r'New size for extend must be greater than current size')),
('0', (r'Invalid input received')),
('size', (r'invalid int value')),
@ -43,7 +43,7 @@ class CinderVolumeExtendNegativeTests(base.ClientTestBase):
params='{0} {1}'.format(self.volume['id'], value))
@ddt.data(
('', (r'too few arguments')),
('', (r'too few arguments|the following arguments are required')),
('1234-1234-1234', (r'No volume with a name or ID of')),
('my_volume', (r'No volume with a name or ID of')),
('1234 1234', (r'unrecognized arguments'))