openstack
/
deb-python-editor
Code Issues Proposed changes

Use /dev/tty by default 

This is because vim (and other terminal editors) typically
output to stdout. This is not very nice behaviour especially
if the program using the editor is piped to some other
program. Hence, using tty is saner.
This commit is contained in:
Eeo Jun 2016-03-31 11:23:02 +08:00
parent d58b00f0de
commit e34758bb2a
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
editor.py
View File

@ -71,7 +71,7 @@ def get_editor():
"Please consider setting your %s variable" % get_platform_editor_var())
def edit(filename=None, contents=None):
def edit(filename=None, contents=None, use_tty=True):
editor = get_editor()
args = get_editor_args(os.path.basename(os.path.realpath(editor)))
args = [editor] + args.split(' ')
@ -85,8 +85,9 @@ def edit(filename=None, contents=None):
f.write(contents)
args += [filename]
extra = {'stdout': open('/dev/tty', 'wb')} if use_tty else {}
proc = subprocess.Popen(args, close_fds=True)
proc = subprocess.Popen(args, close_fds=True, **extra)
proc.communicate()
with open(filename, mode='rb') as f: