openstack
/
deb-python-glance-store
Code Issues Proposed changes

Use HostAddressOpt for store opts that accept IP and hostnames 

The glance_store configuration options: ``sheepdog_store_address``
and ``vmware_server_host`` accept both IP addresses and hostnames.
Since there was no specific OSLO opt type to support this, we were
using ``StrOpt``. The change [1] that added support for
``HostAddressOpt`` type was merged in Ocata and became available for
use with oslo version 3.22.

This patch changes the opt type of these 2 glance_store configuration
options to use this more relevant opt type - HostAddressOpt.

[1] I77bdb64b7e6e56ce761d76696bc4448a9bd325eb

Change-Id: I43fec064815395b8a57e7ef21e43dcbe4d41066e
This commit is contained in:
Dharini Chandrasekar 2017-03-01 22:10:38 +00:00
parent b5d6686f70
commit d6f3c4e2d9
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
glance_store/_drivers/sheepdog.py
View File

@ -87,9 +87,9 @@ Related Options:
* sheepdog_store_address
""")),
cfg.StrOpt('sheepdog_store_address',
default=DEFAULT_ADDR,
help=_("""
cfg.HostAddressOpt('sheepdog_store_address',
default=DEFAULT_ADDR,
help=_("""
Address to bind the Sheepdog daemon to.
Provide a string value representing the address to bind the

6
glance_store/_drivers/vmware_datastore.py
View File

@ -59,9 +59,9 @@ DS_URL_PREFIX = '/folder'
STORE_SCHEME = 'vsphere'
_VMWARE_OPTS = [
cfg.StrOpt('vmware_server_host',
sample_default='127.0.0.1',
help=_("""
cfg.HostAddressOpt('vmware_server_host',
sample_default='127.0.0.1',
help=_("""
Address of the ESX/ESXi or vCenter Server target system.
This configuration option sets the address of the ESX/ESXi or vCenter