openstack
/
deb-python-glanceclient
Code Issues Proposed changes

Replace assertTrue(isinstance()) with assertIsInstance() 

Some of tests use different method of assertTrue(isinstance(A, B))
or assertEqual(type(A), B). The correct way is to use
assertIsInstance(A, B) provided by test tools.

Change-Id: Ibb5e5f848c5632f7c1895c47b8c1a938f2c746c3
This commit is contained in:
Van Hung Pham 2017-06-14 11:03:10 +07:00
parent d3d405cfb2
commit 7791110b2f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glanceclient/tests/unit/test_utils.py
View File

@ -202,7 +202,7 @@ class TestUtils(testtools.TestCase):
# Proxy object should succeed in behaving as the
# wrapped object
self.assertTrue(isinstance(proxy, type(gen_obj)))
self.assertIsInstance(proxy, type(gen_obj))
# Initially request_ids should be empty
self.assertEqual([], proxy.request_ids)