openstack
/
deb-python-ironic-lib
Code Issues Proposed changes

Update notes for submitted changes 

* TrivialFix: Remove cfg import unused
* Add match_root_device_hints() to the utils.py module
* Sync tools/tox_install.sh
* Extend parse_root_device_hints to support operators
* Using assertIsNone() is preferred over assertEqual()
This commit is contained in:
Gerrit Code Review 2016-09-16 13:01:07 +00:00
commit f3c66b48d0
5 changed files with 45 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
36109e58f274b88825ad20e5ed5e249d9799cac2 Normal file
View File

@ -0,0 +1,9 @@
Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com>
Code-Review+2: John L. Villalovos <openstack.org@sodarock.com>
Workflow+1: John L. Villalovos <openstack.org@sodarock.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Tue, 06 Sep 2016 22:13:19 +0000
Reviewed-on: https://review.openstack.org/365905
Project: openstack/deb-python-ironic-lib
Branch: refs/heads/master

9
57a164da157b07aad00d96da6b11c44fbbde2a75 Normal file
View File

@ -0,0 +1,9 @@
Code-Review+2: Jim Rollenhagen <jim@jimrollenhagen.com>
Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com>
Workflow+1: Dmitry Tantsur <divius.inside@gmail.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Thu, 01 Sep 2016 07:57:12 +0000
Reviewed-on: https://review.openstack.org/363086
Project: openstack/deb-python-ironic-lib
Branch: refs/heads/master

9
8429c01ce9f83315a92e77a26b5aa002f29a85e1 Normal file
View File

@ -0,0 +1,9 @@
Code-Review+2: Dmitry Tantsur <divius.inside@gmail.com>
Code-Review+2: John L. Villalovos <openstack.org@sodarock.com>
Workflow+1: John L. Villalovos <openstack.org@sodarock.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Tue, 30 Aug 2016 16:44:05 +0000
Reviewed-on: https://review.openstack.org/362587
Project: openstack/deb-python-ironic-lib
Branch: refs/heads/master

9
96c287d34e29267d4441760d85c2b26042d883b1 Normal file
View File

@ -0,0 +1,9 @@
Code-Review+2: Ruby Loo <ruby.loo@intel.com>
Code-Review+2: Vladyslav Drok <vdrok@mirantis.com>
Workflow+1: Ruby Loo <ruby.loo@intel.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Thu, 01 Sep 2016 18:00:54 +0000
Reviewed-on: https://review.openstack.org/358000
Project: openstack/deb-python-ironic-lib
Branch: refs/heads/master

9
dccd7b17895046d8b34ee9f450900b81a4a266d1 Normal file
View File

@ -0,0 +1,9 @@
Code-Review+2: John L. Villalovos <openstack.org@sodarock.com>
Code-Review+2: Vladyslav Drok <vdrok@mirantis.com>
Workflow+1: Vladyslav Drok <vdrok@mirantis.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Tue, 30 Aug 2016 18:06:59 +0000
Reviewed-on: https://review.openstack.org/348953
Project: openstack/deb-python-ironic-lib
Branch: refs/heads/master