From a713646d06a75ebbca7106813d807dbf4e8b4876 Mon Sep 17 00:00:00 2001 From: Andreas Jaeger Date: Thu, 29 Jun 2017 21:54:59 +0200 Subject: [PATCH] Require bug_project setting If bug_project is not set, do not show the "Report a bug" link. Change-Id: Ifd715d1d46d1b1796d79679c9e954d21e9d09455 --- openstackdocstheme/theme/openstackdocs/layout.html | 7 ++++++- openstackdocstheme/theme/openstackdocs/script_footer.html | 2 -- openstackdocstheme/theme/openstackdocs/titlerow.html | 2 ++ releasenotes/notes/bug_project-d26160cfe5324694.yaml | 4 ++++ 4 files changed, 12 insertions(+), 3 deletions(-) create mode 100644 releasenotes/notes/bug_project-d26160cfe5324694.yaml diff --git a/openstackdocstheme/theme/openstackdocs/layout.html b/openstackdocstheme/theme/openstackdocs/layout.html index 767b497..cf0b090 100644 --- a/openstackdocstheme/theme/openstackdocs/layout.html +++ b/openstackdocstheme/theme/openstackdocs/layout.html @@ -56,7 +56,9 @@ ga('send', 'pageview'); {% if next %} {% endif %} + {%- if bug_project %} + {% endif %}
updated: {{ last_updated }}
@@ -67,8 +69,11 @@ ga('send', 'pageview');
+ are sent to Launchpad projects related to the + document --> + {%- if bug_project %} found an error? report a bug + {%- endif %} questions?
diff --git a/openstackdocstheme/theme/openstackdocs/script_footer.html b/openstackdocstheme/theme/openstackdocs/script_footer.html index 5654a0b..214dfe7 100644 --- a/openstackdocstheme/theme/openstackdocs/script_footer.html +++ b/openstackdocstheme/theme/openstackdocs/script_footer.html @@ -38,8 +38,6 @@ var gitSha = "SHA: {{ gitsha }}"; {%- if bug_project %} var bugProject = "{{ bug_project }}"; - {%- else %} - var bugProject = "openstack-manuals"; {%- endif %} {%- if bug_title %} var bugTitle = "{{ bug_title }}"; diff --git a/openstackdocstheme/theme/openstackdocs/titlerow.html b/openstackdocstheme/theme/openstackdocs/titlerow.html index 3ed8584..9549f61 100644 --- a/openstackdocstheme/theme/openstackdocs/titlerow.html +++ b/openstackdocstheme/theme/openstackdocs/titlerow.html @@ -13,6 +13,8 @@ {% if next %} {% endif %} + {%- if bug_project %} + {% endif %} diff --git a/releasenotes/notes/bug_project-d26160cfe5324694.yaml b/releasenotes/notes/bug_project-d26160cfe5324694.yaml new file mode 100644 index 0000000..2039c45 --- /dev/null +++ b/releasenotes/notes/bug_project-d26160cfe5324694.yaml @@ -0,0 +1,4 @@ +--- +fixes: + - If ``bug_project`` is not set, the "Report a bug" links are not + displayed at all.