openstack
/
deb-python-os-brick
Code Issues Proposed changes

Update notes for submitted changes 

* Stop ignoring H904 hacking rule in tox
* Removed invalid comments in tox.ini [flake8]
* Change code to be more Pythonic
* encryptors: Delay removal of legacy provider names
This commit is contained in:
Gerrit Code Review 2017-05-28 23:51:58 +00:00
parent 0783a57fd0
commit f0f0b0af6b
4 changed files with 37 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
00390448b805086dda1e659e346453c851841fce Normal file
View File

@ -0,0 +1,10 @@
Code-Review+2: Scott DAngelo <scott.dangelo@gmail.com>
Code-Review+1: Kendall Nelson <kennelson11@gmail.com>
Code-Review+2: Sean McGinnis <sean.mcginnis@gmail.com>
Workflow+1: Sean McGinnis <sean.mcginnis@gmail.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Sun, 28 May 2017 23:29:32 +0000
Reviewed-on: https://review.openstack.org/466766
Project: openstack/deb-python-os-brick
Branch: refs/heads/master

9
0ff2c0086ca115560405285368e0bd8b34ce1c88 Normal file
View File

@ -0,0 +1,9 @@
Code-Review+2: Walter A. Boring IV (hemna) <waboring@hemna.com>
Code-Review+2: Sean McGinnis <sean.mcginnis@gmail.com>
Workflow+1: Sean McGinnis <sean.mcginnis@gmail.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Sun, 28 May 2017 23:06:02 +0000
Reviewed-on: https://review.openstack.org/463389
Project: openstack/deb-python-os-brick
Branch: refs/heads/master

9
22f750002578e7a623b50f2f13455765f558875c Normal file
View File

@ -0,0 +1,9 @@
Code-Review+2: Jay Bryant <jungleboyj@electronicjungle.net>
Code-Review+2: Sean McGinnis <sean.mcginnis@gmail.com>
Workflow+1: Sean McGinnis <sean.mcginnis@gmail.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Sun, 28 May 2017 23:29:43 +0000
Reviewed-on: https://review.openstack.org/466555
Project: openstack/deb-python-os-brick
Branch: refs/heads/master

9
a14653b2551633f55ad3ad7c6040e924a75e5508 Normal file
View File

@ -0,0 +1,9 @@
Code-Review+2: Jay Bryant <jungleboyj@electronicjungle.net>
Code-Review+2: Sean McGinnis <sean.mcginnis@gmail.com>
Workflow+1: Sean McGinnis <sean.mcginnis@gmail.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Sun, 28 May 2017 23:29:38 +0000
Reviewed-on: https://review.openstack.org/466554
Project: openstack/deb-python-os-brick
Branch: refs/heads/master