Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 11628 \u003c11628@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11628\u003e replied on the change"}

a5ba980ef4840a13032098bc583d556bbdef2b94

@@ -16,6 +16,23 @@
       "message": "Hi Michael!\n  \nThe \"test_update_records_propagated_to_backends\" in its current manner is testing the exactly a SAME LOGIC for various record types provided by ddt module, so what is wrong in having a single idempotent ID for all? 😕\n\nIn case of failure we could just improve the Error message logged by adding the type in: https://review.opendev.org/c/openstack/designate-tempest-plugin/+/880681/2/designate_tempest_plugin/tests/scenario/v2/test_recordsets.py#b168\nSuch an \"ddt unrolling\" increases the numbers of code lines and I\u0027m not sure it worth.\n\nBTW we have a similar implementation in other places, for example:\nhttps://review.opendev.org/c/openstack/designate-tempest-plugin/+/880681/2/designate_tempest_plugin/tests/scenario/v2/test_recordsets.py#86\nAlso some APIs test doing the same.\n\nThanks!",
       "revId": "a5ba980ef4840a13032098bc583d556bbdef2b94",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "e240a755_119f4b2b",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 2
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 11628
+      },
+      "writtenOn": "2023-04-18T14:34:40Z",
+      "side": 1,
+      "message": "Arkady, yes, DDT will need to eventually be removed from Designate. It defeats the purpose of the idempotent ID being unique per test[1]. This causes problems with refstack testing, etc. We have already unrolled some of the tests[2], this is just continuing that work while fixing a false pass bug.\n\n[1] https://docs.openstack.org/tempest/latest/HACKING.html#test-identification-with-idempotent-id\n[2] https://review.opendev.org/c/openstack/designate-tempest-plugin/+/814497",
+      "revId": "a5ba980ef4840a13032098bc583d556bbdef2b94",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }