From 1096ab98898796810d46113389c372eb4367fe39 Mon Sep 17 00:00:00 2001 From: Erik Olof Gunnar Andersson Date: Fri, 23 Aug 2019 17:19:58 -0700 Subject: [PATCH] Fixing query_client failing with IPv6 * Change query_client to use rsplit to split ip to make sure we can handle IPv6 addresses. * Strip brackets from ip address to make sure dig does not fail if the IPv6 is uri formatted. Change-Id: I2619fab9eb7e35579566cac70e2e718dae474be0 --- designate_tempest_plugin/services/dns/query/query_client.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/designate_tempest_plugin/services/dns/query/query_client.py b/designate_tempest_plugin/services/dns/query/query_client.py index 5c6b0211..da1d1b09 100644 --- a/designate_tempest_plugin/services/dns/query/query_client.py +++ b/designate_tempest_plugin/services/dns/query/query_client.py @@ -60,7 +60,7 @@ class SingleQueryClient(object): @classmethod def _dig(cls, name, rdatatype, ip, port, timeout): query = cls._prepare_query(name, rdatatype) - return dns.query.udp(query, ip, port=port, timeout=timeout) + return dns.query.udp(query, ip.strip('[]'), port=port, timeout=timeout) class Nameserver(object): @@ -78,6 +78,6 @@ class Nameserver(object): @classmethod def from_str(self, nameserver): if ':' in nameserver: - ip, port = nameserver.split(':') + ip, port = nameserver.rsplit(':', 1) return Nameserver(ip, int(port)) return Nameserver(nameserver)