diff --git a/functions-common b/functions-common index 349c765f51..af95bfb879 100644 --- a/functions-common +++ b/functions-common @@ -228,9 +228,9 @@ function err { xtrace=$(set +o | grep xtrace) set +o xtrace local msg="[ERROR] ${BASH_SOURCE[2]}:$1 $2" - echo $msg 1>&2; + echo "$msg" 1>&2; if [[ -n ${LOGDIR} ]]; then - echo $msg >> "${LOGDIR}/error.log" + echo "$msg" >> "${LOGDIR}/error.log" fi $xtrace return $exitcode @@ -283,7 +283,7 @@ function warn { xtrace=$(set +o | grep xtrace) set +o xtrace local msg="[WARNING] ${BASH_SOURCE[2]}:$1 $2" - echo $msg + echo "$msg" $xtrace return $exitcode } @@ -1444,11 +1444,11 @@ function _common_systemd_pitfalls { read -r -d '' msg << EOF || true # read returns 1 for EOF, but it is ok here You are trying to use run_process with sudo, this is not going to work under systemd. -If you need to run a service as a user other than $STACK_USER call it with: +If you need to run a service as a user other than \$STACK_USER call it with: run_process \$name \$cmd \$group \$user EOF - die $LINENO $msg + die $LINENO "$msg" fi if [[ ! "$cmd" =~ ^/ ]]; then @@ -1458,7 +1458,7 @@ start under systemd. Please update your run_process stanza to have an absolute path. EOF - die $LINENO $msg + die $LINENO "$msg" fi }