openstack
/
devstack
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(4 comments)

Patch-set: 1
Reviewer: Gerrit User 13252 <13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, ce6cb287bf2c50e59fbf6063bd20f08d0d2ecf9a
Attention: {"person_ident":"Gerrit User 13252 \u003c13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_13252\u003e replied on the change"}
This commit is contained in:
Gerrit User 13252 2024-04-24 07:49:58 +00:00 committed by Gerrit Code Review
parent ab2def5e74
commit d9e17e6c03
1 changed files with 80 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

80
afddbcafc659bfa63b9b13505754ce13494acbc7
View File

@ -1,5 +1,28 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "5f5653a7_7fde6cf2",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 7,
"author": {
"id": 13252
},
"writtenOn": "2024-04-24T07:49:58Z",
"side": 1,
"message": "remove_uwsgi_config is what this patch changes",
"range": {
"startLine": 7,
"startChar": 36,
"endLine": 7,
"endChar": 52
},
"revId": "afddbcafc659bfa63b9b13505754ce13494acbc7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -16,6 +39,63 @@
"message": "lgtm",
"revId": "afddbcafc659bfa63b9b13505754ce13494acbc7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bc943316_3bd4f7c4",
"filename": "lib/nova",
"patchSetId": 1
},
"lineNbr": 251,
"author": {
"id": 13252
},
"writtenOn": "2024-04-24T07:49:58Z",
"side": 1,
"message": "This seems inconsistent, see below",
"range": {
"startLine": 251,
"startChar": 44,
"endLine": 251,
"endChar": 58
},
"revId": "afddbcafc659bfa63b9b13505754ce13494acbc7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c6d45e6e_00f76d74",
"filename": "lib/nova",
"patchSetId": 1
},
"lineNbr": 552,
"author": {
"id": 13252
},
"writtenOn": "2024-04-24T07:49:58Z",
"side": 1,
"message": "Here you are using only \"nova-api\" as name",
"revId": "afddbcafc659bfa63b9b13505754ce13494acbc7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0e2a2ebd_6e5b4a45",
"filename": "lib/placement",
"patchSetId": 1
},
"lineNbr": 116,
"author": {
"id": 13252
},
"writtenOn": "2024-04-24T07:49:58Z",
"side": 1,
"message": "Maybe switch this to the new style before deprecating it?",
"revId": "afddbcafc659bfa63b9b13505754ce13494acbc7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}