From 18bb66070ad94e448fba155aaaf8c13ca1cba5ac Mon Sep 17 00:00:00 2001 From: Rob Cresswell Date: Tue, 11 Jul 2017 15:33:08 +0100 Subject: [PATCH] Fix default mutable arg in k2k.py Change-Id: I9e8d838315d521874e6f92922a9f488ee7029dbc (cherry picked from commit a0af708a49518937eab3656e7a4302687508a2ce) --- openstack_auth/plugin/k2k.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/openstack_auth/plugin/k2k.py b/openstack_auth/plugin/k2k.py index 03a85f0e..ba4cbf6b 100644 --- a/openstack_auth/plugin/k2k.py +++ b/openstack_auth/plugin/k2k.py @@ -28,7 +28,7 @@ __all__ = ['K2KAuthPlugin'] class K2KAuthPlugin(base.BasePlugin): - def get_plugin(self, service_provider=None, auth_url=None, plugins=[], + def get_plugin(self, service_provider=None, auth_url=None, plugins=None, **kwargs): """Authenticate using keystone to keystone federation. @@ -42,6 +42,9 @@ class K2KAuthPlugin(base.BasePlugin): :returns Keystone2Keystone keystone auth plugin """ + # Avoid mutable default arg for plugins + plugins = plugins or [] + # service_provider being None prevents infinite recursion if utils.get_keystone_version() < 3 or not service_provider: return None