From 1c762b492307a2609835742f073d552744e14c77 Mon Sep 17 00:00:00 2001 From: Michael Krotscheck Date: Tue, 1 Mar 2016 09:42:28 -0800 Subject: [PATCH] Clarified wording in governance This patch clarifies the wording on a few governance statements. First, the intent of the rule approval policy is to encourage more pairs of eyeballs - thus the wording was changed from +5 to 'five positive votes'. Secondly - library upgrades should _never_ change the existing rule set, because they already impose changes due to bugfixes in the rules themselves. Change-Id: I4f2765bcd04cb50da94ac121259c0cc8244bda19 --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 4c0f26f..30dce4e 100644 --- a/README.md +++ b/README.md @@ -21,11 +21,11 @@ If you would like to contribute, please follow [OpenStack's contribution guideli #### Rules only land with consensus Patches that activate, deactivate, or modify rules, should only be merged if a consensus of -reviewers is reached. In this case, consensus means at least five +1 votes, with no -1 votes. Cores -may not override and/or ignore -1 votes. +reviewers is reached. In this case, consensus means at least five positive votes (+1 or +2), +with no -1 votes. Cores may not override and/or ignore -1 votes. #### Library upgrades require two cores -Patches that upgrade eslint only require two core approvers to land. These patches should add new +Patches that upgrade eslint only require two core approvers to land. These patches must add new upstream rules in a deactivated state, and delete any deprecated rules. #### Policy upgrades require all cores