From 4f5cae9232bce9c335769e1b327658b05ce173e1 Mon Sep 17 00:00:00 2001 From: Elizabeth Elwell Date: Wed, 3 Aug 2016 12:39:34 +0100 Subject: [PATCH] Upgraded eslint to 3.0.0 This upgrades the eslint version to 3.0.0, removes zombie rules, and ensures all new rules are disabled. Change-Id: I8ea98aeda7a42ed0e140164c0e9d5e28d54794b8 --- .eslintrc | 65 ++++++++++++++++++++++++++++++++++++++++++++++------ package.json | 4 ++-- 2 files changed, 60 insertions(+), 9 deletions(-) diff --git a/.eslintrc b/.eslintrc index b0fde17..d708219 100644 --- a/.eslintrc +++ b/.eslintrc @@ -59,12 +59,6 @@ rules: # Possible Errors ############################################################################# - # Disallow trailing commas, as those break some browsers. - # http://eslint.org/docs/rules/comma-dangle - comma-dangle: - - 2 - - "never" - # Prevent the assignment of a variable in a conditional. # http://eslint.org/docs/rules/no-cond-assign no-cond-assign: 2 @@ -97,6 +91,11 @@ rules: # http://eslint.org/docs/rules/no-duplicate-case no-duplicate-case: 2 + # Do not require that all imports from a single module exist in a single + # import statement. + #http://eslint.org/docs/rules/no-duplicate-imports + no-duplicate-imports: 0 + # Disallow empty regex character classes. (/[]/) # http://eslint.org/docs/rules/no-empty-character-class no-empty-character-class: 2 @@ -139,6 +138,10 @@ rules: # http://eslint.org/docs/rules/no-irregular-whitespace no-irregular-whitespace: 2 + # Allow mixes of different operators without parantheses + # http://eslint.org/docs/rules/no-mixed-operators + no-mixed-operators: 0 + # Disallow negation of the left operand of an in expression # http://eslint.org/docs/rules/no-negated-in-lhs no-negated-in-lhs: 2 @@ -147,6 +150,10 @@ rules: # http://eslint.org/docs/rules/no-obj-calls no-obj-calls: 2 + # Allow use of Object.prototypes builtins directly + # http://eslint.org/docs/rules/no-prototype-builtins + no-prototype-builtins: 0 + # Disallow multiple spaces in a regular expression literal # http://eslint.org/docs/rules/no-regex-spaces no-regex-spaces: 2 @@ -159,6 +166,22 @@ rules: # http://eslint.org/docs/rules/no-unreachable no-unreachable: 2 + # Re-allow return, throw, break, and continue statements inside finally blocks. + # http://eslint.org/docs/rules/no-unsafe-finally + no-unsafe-finally: 0 + + # Allow unnecessary computed property keys on objects + # http://eslint.org/docs/rules/no-useless-computed-key + no-useless-computed-key: 0 + + # Allow unnecessary escape usage + # http://eslint.org/docs/rules/no-useless-escape + no-useless-escape: 0 + + # Allow renaming import, export, and destructured assignments to the same name + # http://eslint.org/docs/rules/no-useless-rename + no-useless-rename: 0 + # Disallow comparisons with the value NaN # http://eslint.org/docs/rules/use-isnan use-isnan: 2 @@ -581,6 +604,10 @@ rules: - 2 - properties: "never" + # Do not require or disallow trailing commas + # http://eslint.org/docs/rules/comma-dangle + comma-dangle: 0 + # Enforce spacing before and after comma # http://eslint.org/docs/rules/comma-spacing comma-spacing: 0 @@ -652,12 +679,20 @@ rules: - 2 - "unix" + # Do not enforce a maximum file length + # http://eslint.org/docs/rules/max-lines + max-lines: 0 + # Specify the maximum depth callbacks can be nested # http://eslint.org/docs/rules/max-nested-callbacks max-nested-callbacks: - 0 - 3 + # Do not enforce a maximum number of statements allowed per line + #http://eslint.org/docs/rules/max-statements-per-line + max-statements-per-line: 0 + # Require a capital letter for constructors # http://eslint.org/docs/rules/new-cap new-cap: 0 @@ -704,7 +739,7 @@ rules: - 2 - max: 1 - # disallow negated conditions + # Disallow negated conditions # http://eslint.org/docs/rules/no-negated-condition no-negated-condition: 0 @@ -744,10 +779,18 @@ rules: # http://eslint.org/docs/rules/no-whitespace-before-property no-whitespace-before-property: 0 + # Do not enforce consistent line breaks inside braces + # http://eslint.org/docs/rules/object-curly-newline + object-curly-newline: 0 + # Require or disallow padding inside curly braces # http://eslint.org/docs/rules/object-curly-spacing object-curly-spacing: 0 + # Do not enforce placing object properties on separate lines + # http://eslint.org/docs/rules/object-property-newline + object-property-newline: 0 + # Allow or disallow one variable declaration per function # http://eslint.org/docs/rules/one-var one-var: @@ -787,6 +830,10 @@ rules: # http://eslint.org/docs/rules/require-jsdoc require-jsdoc: 0 + # Do not enforce spacing between rest and spread operators and their expressions + # http://eslint.org/docs/rules/rest-spread-spacing + rest-spread-spacing: 0 + # Enforce spacing before and after semicolons # http://eslint.org/docs/rules/semi-spacing semi-spacing: @@ -841,6 +888,10 @@ rules: # http://eslint.org/docs/rules/spaced-comment spaced-comment: 0 + # Do not require or disallow the Unicode Byte Order Mark (BOM) + # http://eslint.org/docs/rules/unicode-bom + unicode-bom: 0 + # require regex literals to be wrapped in parentheses # http://eslint.org/docs/rules/wrap-regex wrap-regex: 0 diff --git a/package.json b/package.json index 8fe39c1..5f35222 100644 --- a/package.json +++ b/package.json @@ -32,10 +32,10 @@ }, "homepage": "https://wiki.openstack.org/wiki/QA", "peerDependencies": { - "eslint": "^2.4.0" + "eslint": "^3.0.0" }, "devDependencies": { - "eslint": "2.4.0", + "eslint": "3.0.0", "jasmine": "2.3.1" }, "dependencies": {