diff --git a/freezer/job.py b/freezer/job.py index db441ece..d343989e 100644 --- a/freezer/job.py +++ b/freezer/job.py @@ -152,8 +152,7 @@ class BackupJob(Job): LOG.error('Error while sync exec: {0}'.format(err)) except Exception as error: LOG.error('Error while sync exec: {0}'.format(error)) - if not self.conf.mode: - raise ValueError("Empty mode") + mod_name = 'freezer.mode.{0}.{1}'.format( self.conf.mode, self.conf.mode.capitalize() + 'Mode') app_mode = importutils.import_object(mod_name, self.conf) diff --git a/freezer/tests/unit/test_job.py b/freezer/tests/unit/test_job.py index ef80a1d0..25013fe5 100644 --- a/freezer/tests/unit/test_job.py +++ b/freezer/tests/unit/test_job.py @@ -60,13 +60,6 @@ class TestBackupJob(TestJob): job = jobs.BackupJob(backup_opt, backup_opt.storage) self.assertRaises(Exception, job.execute) # noqa - def test_execute_raise(self): - backup_opt = commons.BackupOpt1() - backup_opt.no_incremental = False - backup_opt.mode = None - job = jobs.BackupJob(backup_opt, backup_opt.storage) - self.assertRaises(ValueError, job.execute) # noqa - class TestAdminJob(TestJob): def setUp(self):