openstack
/
fuel-plugin-murano
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review-1

(7 comments)

Minor nits inline. Thanks!

Patch-set: 7
Reviewer: Gerrit User 14947 <14947@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 14947 2016-09-23 14:58:28 +00:00 committed by Gerrit Code Review
parent 5055f606d4
commit f90388de04
1 changed files with 165 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

165
ba1c646bf8db656dbf513468a7270ac1d428efe5 Normal file
View File

@ -0,0 +1,165 @@
{
"comments": [
{
"key": {
"uuid": "5a8bc5a2_bcff0166",
"filename": "releasenotes/notes/abstract-base-class-fix-7cb06a0924b973f3.yaml",
"patchSetId": 7
},
"lineNbr": 3,
"author": {
"id": 14947
},
"writtenOn": "2016-09-23T14:58:28Z",
"side": 1,
"message": "remove",
"range": {
"startLine": 3,
"startChar": 34,
"endLine": 3,
"endChar": 35
},
"revId": "ba1c646bf8db656dbf513468a7270ac1d428efe5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_9c7de5e9",
"filename": "releasenotes/notes/abstract-base-class-fix-7cb06a0924b973f3.yaml",
"patchSetId": 7
},
"lineNbr": 4,
"author": {
"id": 14947
},
"writtenOn": "2016-09-23T14:58:28Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 4,
"startChar": 32,
"endLine": 4,
"endChar": 52
},
"revId": "ba1c646bf8db656dbf513468a7270ac1d428efe5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_3c313106",
"filename": "releasenotes/notes/delete-app-in-env-template-d8e07d3b860f0441.yaml",
"patchSetId": 7
},
"lineNbr": 2,
"author": {
"id": 14947
},
"writtenOn": "2016-09-23T14:58:28Z",
"side": 1,
"message": "The issue is fixed.",
"range": {
"startLine": 2,
"startChar": 109,
"endLine": 2,
"endChar": 109
},
"revId": "ba1c646bf8db656dbf513468a7270ac1d428efe5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_1f10e74d",
"filename": "releasenotes/notes/global-inherits-fix-6da007ec44a774f2.yaml",
"patchSetId": 7
},
"lineNbr": 4,
"author": {
"id": 14947
},
"writtenOn": "2016-09-23T14:58:28Z",
"side": 1,
"message": "Previously,",
"range": {
"startLine": 4,
"startChar": 22,
"endLine": 4,
"endChar": 32
},
"revId": "ba1c646bf8db656dbf513468a7270ac1d428efe5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_3f92039f",
"filename": "releasenotes/notes/new-type-format-in-object-model-da6976291057ab31.yaml",
"patchSetId": 7
},
"lineNbr": 3,
"author": {
"id": 14947
},
"writtenOn": "2016-09-23T14:58:28Z",
"side": 1,
"message": "Previously,",
"range": {
"startLine": 3,
"startChar": 57,
"endLine": 3,
"endChar": 67
},
"revId": "ba1c646bf8db656dbf513468a7270ac1d428efe5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_5fb6ef3d",
"filename": "releasenotes/notes/new-type-format-in-object-model-da6976291057ab31.yaml",
"patchSetId": 7
},
"lineNbr": 7,
"author": {
"id": 14947
},
"writtenOn": "2016-09-23T14:58:28Z",
"side": 1,
"message": "typo",
"range": {
"startLine": 7,
"startChar": 5,
"endLine": 7,
"endChar": 6
},
"revId": "ba1c646bf8db656dbf513468a7270ac1d428efe5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_ffc5fb8d",
"filename": "releasenotes/notes/osc-murano-url-507932234b49cf9f.yaml",
"patchSetId": 7
},
"lineNbr": 3,
"author": {
"id": 14947
},
"writtenOn": "2016-09-23T14:58:28Z",
"side": 1,
"message": "no comma",
"range": {
"startLine": 3,
"startChar": 62,
"endLine": 3,
"endChar": 63
},
"revId": "ba1c646bf8db656dbf513468a7270ac1d428efe5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}