Update patch set 4

Patch Set 4: Code-Review-2 (1 comment) Patch-set: 4
2017-01-11 17:29:10 +00:00 · 2017-01-11 17:29:10 +00:00 · c4323aa788
parent 2d83e4030e
commit c4323aa788
1 changed files with 27 additions and 0 deletions
--- a/27
+++ b/27
@ -0,0 +1,27 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "ba5201f7_00ef8be9",
+        "filename": "fuel_plugin_builder/actions/build.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 153,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2017-01-11T17:29:10Z",
+      "side": 1,
+      "message": "I\u0027m struggling to understand, why we continue hardcoding paths all over the code, when we have a dedicated place for that, which can be extended easily extended. \n\nhttps://github.com/openstack/fuel-plugins/blob/master/fuel_plugin_builder/version_mapping.py#L26-L58\n\nhttps://github.com/openstack/fuel-plugins/blob/master/fuel_plugin_builder/actions/build.py#L272-L281",
+      "range": {
+        "startLine": 153,
+        "startChar": 8,
+        "endLine": 153,
+        "endChar": 41
+      },
+      "revId": "6a1ae7f5204dadcdc5326c668c09ca5840bd5c7e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}