Warn on run_on_remote, execute_remote_cmd and run_on_remote_get_results call

Warn on run_on_remote, execute_remote_cmd and  run_on_remote_get_results call
SSHManager().execute_on_remote marked as deprecated in favor of
SSHManager().check_call

Change-Id: I2615e910d294f465dd6599ae28091ab2eab2cc03

fuelweb_test/helpers/ssh_manager.py

@@ -222,6 +222,12 @@ class SSHManager(object):
         :return: dict
         :raise: Exception
         """
+        warn(
+            'SSHManager().execute_on_remote is deprecated in favor of '
+            'SSHManager().check_call.\n'
+            'Please, do not use this method in any new tests. '
+            'Old code will be updated later.'
+        )
         if assert_ec_equal is None:
             assert_ec_equal = [0]
 

fuelweb_test/helpers/utils.py

@@ -457,13 +457,15 @@ def cond_upload(remote, source, target, condition=''):
 
 
 def run_on_remote(*args, **kwargs):
-    warn(
-        'This is old deprecated method, which should not be used anymore. '
-        'please use remote.execute() and remote.check_call() instead.\n'
+    msg = (
+        'run_on_remote() is old deprecated method, '
+        'which should not be used anymore. '
+        'please use remote.check_call() instead.\n'
         'Starting from fuel-devops 2.9.22 this methods will return all '
-        'required data.',
-        DeprecationWarning
-    )
+        'required data.\n'
+        '{}'.format("".join(traceback.format_stack())))
+    warn(msg, DeprecationWarning)
+    logger.warning(msg)
     if 'jsonify' in kwargs:
         if kwargs['jsonify']:
             return run_on_remote_get_results(*args, **kwargs)['stdout_json']
@@ -486,16 +488,23 @@ def run_on_remote_get_results(remote, cmd, clear=False, err_msg=None,
     :return: dict
     :raise: Exception
     """
-    warn(
-        'run_on_remote_get_results() is deprecated in favor of '
-        'remote.check_call() \n'
-        'Starting from fuel-devops 2.9.22 this methods will return whole '
-        'required data.',
-        DeprecationWarning
-    )
+    msg = (
+        'run_on_remote_get_results() is old deprecated method, '
+        'which should not be used anymore. '
+        'please use remote.check_call() instead.\n'
+        'Starting from fuel-devops 2.9.22 this methods will return all '
+        'required data.\n'
+        '{}'.format("".join(traceback.format_stack())))
+    warn(msg, DeprecationWarning)
+    logger.warning(msg)
     if assert_ec_equal is None:
         assert_ec_equal = [0]
-    orig_result = remote.execute(cmd)
+    orig_result = remote.check_call(
+        command=cmd,
+        error_info=err_msg,
+        expected=assert_ec_equal,
+        raise_on_err=raise_on_assert
+    )
 
     # now create fallback result for compatibility reasons (UTF-8)
 
@@ -507,43 +516,11 @@ def run_on_remote_get_results(remote, cmd, clear=False, err_msg=None,
         'stderr_str': ''.join(orig_result['stderr']).strip()
     }
 
-    details_log = (
-        "Host:      {host}\n"
-        "Command:   '{cmd}'\n"
-        "Exit code: {code}\n"
-        "STDOUT:\n{stdout}\n"
-        "STDERR:\n{stderr}".format(
-            host=remote.host, cmd=cmd, code=result['exit_code'],
-            stdout=result['stdout_str'], stderr=result['stderr_str']
-        ))
-
-    if result['exit_code'] not in assert_ec_equal:
-        error_msg = (
-            err_msg or
-            "Unexpected exit_code returned: actual {0}, expected {1}."
-            "".format(
-                result['exit_code'],
-                ' '.join(map(str, assert_ec_equal))))
-        log_msg = (
-            "{0}  Command: '{1}'  "
-            "Details:\n{2}".format(
-                error_msg, cmd, details_log))
-        logger.error(log_msg)
-        if raise_on_assert:
-            raise Exception(log_msg)
-
     if clear:
         remote.clear()
 
     if jsonify:
-        try:
-            result['stdout_json'] = json_deserialize(result['stdout_str'])
-        except Exception:
-            error_msg = (
-                "Unable to deserialize output of command"
-                " '{0}' on host {1}".format(cmd, remote.host))
-            logger.error(error_msg)
-            raise Exception(error_msg)
+        result['stdout_json'] = orig_result.stdout_json
 
     return result
 

fuelweb_test/models/environment.py

@@ -15,6 +15,7 @@
 import logging
 import re
 import time
+import traceback
 from warnings import warn
 
 from devops.helpers.helpers import tcp_ping_
@@ -725,15 +726,19 @@ class EnvironmentModel(object):
     @staticmethod
     @logwrap
     def execute_remote_cmd(remote, cmd, exit_code=0):
-        warn(
-            'execute_remote_cmd(remote, cmd) is deprecated in favor of '
-            'SSHClient().check_call()',
-            DeprecationWarning
+        msg = (
+            'execute_remote_cmd() is old deprecated method, '
+            'which should not be used anymore. '
+            'please use remote.check_call() instead.\n'
+            'Starting from fuel-devops 2.9.22 this methods will return all '
+            'required data.\n'
+            '{}'.format("".join(traceback.format_stack())))
+        warn(msg, DeprecationWarning)
+        logger.warning(msg)
+        result = remote.check_call(
+            command=cmd,
+            expected=[exit_code],
         )
-        result = remote.execute(cmd)
-        assert_equal(result['exit_code'], exit_code,
-                     'Failed to execute "{0}" on remote host: {1}'.
-                     format(cmd, result))
         return result['stdout']
 
     @logwrap