Update patch set 27

Patch Set 27:

(1 comment)

Patch-set: 27
Reviewer: Gerrit User 10391 <10391@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 10391 2016-11-02 09:11:07 +00:00 committed by Gerrit Code Review
parent fba46e798f
commit 10f48069a4
1 changed files with 27 additions and 0 deletions

View File

@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "ba5da102_8df73558",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 27
},
"lineNbr": 40,
"author": {
"id": 10391
},
"writtenOn": "2016-11-02T09:11:07Z",
"side": 1,
"message": "I\u0027m concerns about these ones. If we are going this way, tag is nothing but a role. In that case, why do we need a new entity at all? All we need is to introduce more roles and rewrite tasks to use them as well as make possible to define roles for cluster. I want to emphasize again: we *do not* need tags in this case. Let\u0027s adopt roles instead. If we don\u0027t do this we will end up with a lot of bugs and misunderstanding since it won\u0027t be clear:\n\n* what should happen to assigned tags if original role (the one that brings tags to node) moved to another node?\n* what should happen if assigned role is changed and now has another list of tags?\n* what should happen if user manually move one tag from host A to host, and then move the original role (the one that brings this tag) from host A to host C? should be reintroduce this tag on host C? or maybe we need to reintroduce it once again? should we keep it on host C?\n\nAnd so on and so forth. I have a lot of questions here. Trying to solve them will introduce even more complexity and confusion. That\u0027s why I don\u0027t understand why we are trying to write role replacements. On the other hand, I see benefits of using \"tags\" in a slightly another way. To me tags is not a role replacement, it\u0027s a deployment unit. We should not assign tags to nodes. Instead, we need to get a list of tags based on assigned roles. If one wants to change deployment, he/she just need to move tags from one role to another. And in that case, we don\u0027t need tags assign/unassign operations for nodes.\n\nPlease, tell me where I\u0027m wrong and what I missed?",
"range": {
"startLine": 39,
"startChar": 0,
"endLine": 40,
"endChar": 28
},
"revId": "3f8648848d4309c3b840ac33a8ca15bb7a34a4b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}