Update patch set 12

Patch Set 12: Code-Review-1

(2 comments)

Please look at my inline comment about upgrade impact. Sorry for not mentioning it earlier.

Patch-set: 12
Label: Code-Review=-1
This commit is contained in:
Gerrit User 13717 2016-11-07 16:01:18 +00:00 committed by Gerrit Code Review
parent 31db1b9962
commit 41fcf1d465
1 changed files with 41 additions and 0 deletions

View File

@ -50,6 +50,47 @@
"revId": "3edf9a7596ec4cdce67cefe151357feb026f2d53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a629dbe_387273e6",
"filename": "specs/11.0/security-groups-support-for-ovs.rst",
"patchSetId": 12
},
"lineNbr": 65,
"author": {
"id": 13717
},
"writtenOn": "2016-11-07T16:01:18Z",
"side": 1,
"message": "+1, maybe if put this way it will be better:\n\n... choose this driver for OVS based security groups implementation and\n... choose this driver for iptables/linux bridge based security groups implementation?",
"parentUuid": "9a629dbe_60c7e345",
"revId": "3edf9a7596ec4cdce67cefe151357feb026f2d53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a629dbe_2320889b",
"filename": "specs/11.0/security-groups-support-for-ovs.rst",
"patchSetId": 12
},
"lineNbr": 116,
"author": {
"id": 13717
},
"writtenOn": "2016-11-07T16:01:18Z",
"side": 1,
"message": "Sorry, I didn\u0027t mention it earlier - there is a certain upgrade procedure for compute nodes. Please refer to http://docs.openstack.org/developer/neutron/devref/openvswitch_firewall.html, \"Upgrade path from iptables hybrid driver\"",
"range": {
"startLine": 112,
"startChar": 0,
"endLine": 116,
"endChar": 4
},
"revId": "3edf9a7596ec4cdce67cefe151357feb026f2d53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}