Update patch set 2
Patch Set 2: Code-Review-1 (2 comments) Patch-set: 2 Reviewer: Gerrit User 11827 <11827@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
1af3f6536c
commit
425af9c2f0
|
@ -0,0 +1,44 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6895a0_9e6ed42d",
|
||||
"filename": "specs/10.0/tasks-inheritance.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 150,
|
||||
"author": {
|
||||
"id": 11827
|
||||
},
|
||||
"writtenOn": "2016-10-24T11:47:20Z",
|
||||
"side": 1,
|
||||
"message": "significant",
|
||||
"range": {
|
||||
"startLine": 150,
|
||||
"startChar": 46,
|
||||
"endLine": 150,
|
||||
"endChar": 57
|
||||
},
|
||||
"revId": "e665201bab84adbabcc96c862c8dea5b058ba372",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6895a0_be50f85f",
|
||||
"filename": "specs/10.0/tasks-inheritance.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 214,
|
||||
"author": {
|
||||
"id": 11827
|
||||
},
|
||||
"writtenOn": "2016-10-24T11:47:20Z",
|
||||
"side": 1,
|
||||
"message": "I believe we should implement tests which won\u0027t allow us to write an inheritance with loops, e.g.:\n\nA \u003d {\"k\": \"a\"}\nB \u003d {\"k\": \"b\"}\nC \u003d {\"inherited\": [\"A\", \"B\"]}\nD \u003d {\"inherited\": [\"B\", \"A\"]}\nE \u003d {\"inherited\": [\"C\", \"D\"]}\n\nIn this case C3 won\u0027t work and we want know about this before cluster will started to serialize.",
|
||||
"revId": "e665201bab84adbabcc96c862c8dea5b058ba372",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue