Update patch set 10

Patch Set 10: Code-Review-1 (5 comments) Patch-set: 10 Label: Code-Review=-1
2016-11-01 13:35:43 +00:00 · 2016-11-01 13:35:43 +00:00 · 5e0dd5f800
parent 1a6998d8f0
commit 5e0dd5f800
1 changed files with 119 additions and 0 deletions
--- a/119
+++ b/119
@ -0,0 +1,119 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "ba5da102_3706921d",
+        "filename": "specs/11.0/security-groups-support-for-ovs.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 23,
+      "author": {
+        "id": 13717
+      },
+      "writtenOn": "2016-11-01T13:35:43Z",
+      "side": 1,
+      "message": "The meaning of the sentence is unclear to me. Do you mean that ovs firewall will be the default one?",
+      "range": {
+        "startLine": 22,
+        "startChar": 28,
+        "endLine": 23,
+        "endChar": 17
+      },
+      "revId": "764389b1fb0ac196bcfabdd5984f33a965d14b79",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba5da102_d732b6f1",
+        "filename": "specs/11.0/security-groups-support-for-ovs.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 61,
+      "author": {
+        "id": 13717
+      },
+      "writtenOn": "2016-11-01T13:35:43Z",
+      "side": 1,
+      "message": "a typo s/Brige/Bridge",
+      "range": {
+        "startLine": 61,
+        "startChar": 81,
+        "endLine": 61,
+        "endChar": 86
+      },
+      "revId": "764389b1fb0ac196bcfabdd5984f33a965d14b79",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba5da102_b7e62213",
+        "filename": "specs/11.0/security-groups-support-for-ovs.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 78,
+      "author": {
+        "id": 13717
+      },
+      "writtenOn": "2016-11-01T13:35:43Z",
+      "side": 1,
+      "message": "Didn\u0027t get this one :(",
+      "range": {
+        "startLine": 78,
+        "startChar": 0,
+        "endLine": 78,
+        "endChar": 45
+      },
+      "revId": "764389b1fb0ac196bcfabdd5984f33a965d14b79",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba5da102_57f14600",
+        "filename": "specs/11.0/security-groups-support-for-ovs.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 215,
+      "author": {
+        "id": 13717
+      },
+      "writtenOn": "2016-11-01T13:35:43Z",
+      "side": 1,
+      "message": "degradation",
+      "range": {
+        "startLine": 215,
+        "startChar": 2,
+        "endLine": 215,
+        "endChar": 13
+      },
+      "revId": "764389b1fb0ac196bcfabdd5984f33a965d14b79",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba5da102_97fbdec0",
+        "filename": "specs/11.0/security-groups-support-for-ovs.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 223,
+      "author": {
+        "id": 13717
+      },
+      "writtenOn": "2016-11-01T13:35:43Z",
+      "side": 1,
+      "message": "Nit: As far as I understand, choosing a correct firewall_driver is not a flag anymore",
+      "range": {
+        "startLine": 223,
+        "startChar": 2,
+        "endLine": 223,
+        "endChar": 12
+      },
+      "revId": "764389b1fb0ac196bcfabdd5984f33a965d14b79",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}