Update patch set 27

Patch Set 27:

(7 comments)

Patch-set: 27
Reviewer: Gerrit User 8749 <8749@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0

3f8648848d4309c3b840ac33a8ca15bb7a34a4b6

@@ -118,6 +118,150 @@
       "revId": "3f8648848d4309c3b840ac33a8ca15bb7a34a4b6",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba5da102_5e701772",
+        "filename": "specs/10.0/role-decomposition.rst",
+        "patchSetId": 27
+      },
+      "lineNbr": 40,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2016-11-03T18:13:57Z",
+      "side": 1,
+      "message": "Agree that having both roles and tags with special rules of interaction between those will definitely create a lot of confusion and uncertainty. Also roles must not be static and many users require that.\n\nAnother concern is we already have \"Component\" entity in Nailgun, with dependencies and some basic validation, what you are describing looks like \"Component\" which is more granular entity than Role.\n\nI\u0027m probably ok with having a role represented as a set of tasks to simplify UX, but it MUST be deterministic, during the flow I shouldn\u0027t start removing tags from the node, when it has assigned role, which has the task, otherwise during life-time of your cluster, roles will tell you nothing about the node and it will be a complete mess. If role is a helper to set tags/tasks, it should have filtration mechanism, based on which, we can determine which tasks to include, see how selectors mechanism is done in Kubernetes [1]. When user wants to remove a tag (i.e. set of tasks) from the cluster, he must go and fix tags selector for the role.\n\n[1] http://kubernetes.io/docs/user-guide/labels/",
+      "parentUuid": "ba5da102_b193405a",
+      "range": {
+        "startLine": 39,
+        "startChar": 0,
+        "endLine": 40,
+        "endChar": 28
+      },
+      "revId": "3f8648848d4309c3b840ac33a8ca15bb7a34a4b6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba5da102_3d9b6c67",
+        "filename": "specs/10.0/role-decomposition.rst",
+        "patchSetId": 27
+      },
+      "lineNbr": 179,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2016-11-03T18:13:57Z",
+      "side": 1,
+      "message": "It should be something like:\n\n    -  node_id: node-1:\n        tags: [\u0027corosync:1\u0027, \u0027mysql:2\u0027]",
+      "range": {
+        "startLine": 178,
+        "startChar": 0,
+        "endLine": 179,
+        "endChar": 37
+      },
+      "revId": "3f8648848d4309c3b840ac33a8ca15bb7a34a4b6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba5da102_5d70200b",
+        "filename": "specs/10.0/role-decomposition.rst",
+        "patchSetId": 27
+      },
+      "lineNbr": 231,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2016-11-03T18:13:57Z",
+      "side": 1,
+      "message": "Here I stopped understanding the tags. So tag\u0027s name is controller? Reading information from above, I thought tags is mechanism which allows to granularly assign tasks to nodes.",
+      "range": {
+        "startLine": 231,
+        "startChar": 6,
+        "endLine": 231,
+        "endChar": 16
+      },
+      "revId": "3f8648848d4309c3b840ac33a8ca15bb7a34a4b6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba5da102_5d0f4036",
+        "filename": "specs/10.0/role-decomposition.rst",
+        "patchSetId": 27
+      },
+      "lineNbr": 242,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2016-11-03T18:13:57Z",
+      "side": 1,
+      "message": "Hm, where is primary key id?",
+      "revId": "3f8648848d4309c3b840ac33a8ca15bb7a34a4b6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba5da102_f82bc27f",
+        "filename": "specs/10.0/role-decomposition.rst",
+        "patchSetId": 27
+      },
+      "lineNbr": 246,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2016-11-03T18:13:57Z",
+      "side": 1,
+      "message": "Also where is a human readable name?",
+      "revId": "3f8648848d4309c3b840ac33a8ca15bb7a34a4b6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba5da102_586bceb6",
+        "filename": "specs/10.0/role-decomposition.rst",
+        "patchSetId": 27
+      },
+      "lineNbr": 285,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2016-11-03T18:13:57Z",
+      "side": 1,
+      "message": "If it\u0027s tag creation it must be a POST request with all required data not in GET, but in the body of POST request.\n\nMake sure that it\u0027s follows openstack api guide\n\nhttp://specs.openstack.org/openstack/api-wg/guidelines/pagination_filter_sort.html#filtering",
+      "revId": "3f8648848d4309c3b840ac33a8ca15bb7a34a4b6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba5da102_b8b30a4c",
+        "filename": "specs/10.0/role-decomposition.rst",
+        "patchSetId": 27
+      },
+      "lineNbr": 326,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2016-11-03T18:13:57Z",
+      "side": 1,
+      "message": "Why is it expected? Why adding tags would break plugins? Plugins rely on dependencies which as far as I understand won\u0027t be removed.",
+      "range": {
+        "startLine": 326,
+        "startChar": 5,
+        "endLine": 326,
+        "endChar": 13
+      },
+      "revId": "3f8648848d4309c3b840ac33a8ca15bb7a34a4b6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
     }
   ]
 }