openstack
/
fuel-ui
Code Issues Proposed changes

Merge "Complexity warning fix"

This commit is contained in:
Jenkins 2016-03-11 14:07:56 +00:00 committed by Gerrit Code Review
parent 385fea48f1 e075cd92ce
commit df15247de3
1 changed files with 31 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
static/views/dialogs.js
View File

@ -958,43 +958,38 @@ export var ShowNodeInfoDialog = React.createClass({
},
showSummary(group) {
var meta = this.props.node.get('meta');
var formatSummary = (dict) => _.keys(dict).sort().map((key) => dict[key] + ' x ' + key);
var summaryToString = (summary) =>
_.keys(summary).sort().map((key) => summary[key] + ' x ' + key);
var summaryFormatters = {
system: () => [meta.system.manufacturer || '', meta.system.product || ''].join(' '),
memory: () =>
(
_.isArray(meta.memory.devices) ?
summaryToString(
_.countBy(_.pluck(meta.memory.devices, 'size'), (value) => utils.showSize(value))
)
:
[]
)
.concat(utils.showSize(meta.memory.total) + ' ' + i18n('dialog.show_node.total'))
.join(', '),
disks: () => meta.disks.length + ' ' +
i18n('dialog.show_node.drive', {count: meta.disks.length}) + ', ' +
utils.showSize(_.reduce(_.pluck(meta.disks, 'size'), (sum, n) => sum + n, 0)) + ' ' +
i18n('dialog.show_node.total'),
cpu: () => summaryToString(
_.countBy(_.pluck(meta.cpu.spec, 'frequency'), utils.showFrequency)
).join(', '),
interfaces: () => summaryToString(
_.countBy(_.pluck(meta.interfaces, 'current_speed'), utils.showBandwidth)
).join(', '),
numa_topology: () => i18n('dialog.show_node.numa_nodes', {
count: meta.numa_topology.numa_nodes.length
}),
default: () => ''
};
try {
switch (group) {
case 'system':
return (meta.system.manufacturer || '') + ' ' + (meta.system.product || '');
case 'memory':
return (
_.isArray(meta.memory.devices) ?
formatSummary(
_.countBy(_.pluck(meta.memory.devices, 'size'), (value) => utils.showSize(value))
)
:
[]
)
.concat(utils.showSize(meta.memory.total) + ' ' + i18n('dialog.show_node.total'))
.join(', ');
case 'disks':
return meta.disks.length + ' ' +
i18n('dialog.show_node.drive', {count: meta.disks.length}) + ', ' +
utils.showSize(_.reduce(_.pluck(meta.disks, 'size'), (sum, n) => sum + n, 0)) + ' ' +
i18n('dialog.show_node.total');
case 'cpu':
return formatSummary(
_.countBy(_.pluck(meta.cpu.spec, 'frequency'), utils.showFrequency)
).join(', ');
case 'interfaces':
return formatSummary(
_.countBy(_.pluck(meta.interfaces, 'current_speed'), utils.showBandwidth)
).join(', ');
case 'numa_topology':
return i18n('dialog.show_node.numa_nodes', {
count: meta.numa_topology.numa_nodes.length
});
default:
return '';
}
return (summaryFormatters[group] || summaryFormatters.default)();
} catch (ignore) {}
},
showPropertyName(propertyName) {