openstack
/
glance
Code Issues Proposed changes

Fix wrong parameters order in Task 

According to Task class in glance.domain.__init__ .py, 'message'
should after 'result' in TaskFactory.new_task.

Closes-bug: #1488303
Change-Id: I70b0a27b5dbff0e762e2d9b162bea29147816c55
This commit is contained in:
wangxiyuan 2015-08-24 16:27:16 +08:00
parent c4ef8f979a
commit 1883eada3f
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glance/domain/__init__.py
View File

@ -477,8 +477,8 @@ class TaskFactory(object):
created_at,
updated_at,
task_input,
kwargs.get('message'),
kwargs.get('result'),
kwargs.get('message')
)

8
glance/tests/unit/test_domain.py
View File

@ -326,7 +326,9 @@ class TestTaskFactory(test_utils.BaseTestCase):
owner = TENANT1
task_input = 'input'
task = self.task_factory.new_task(task_type, owner,
task_input=task_input)
task_input=task_input,
result='test_result',
message='test_message')
self.assertIsNotNone(task.task_id)
self.assertIsNotNone(task.created_at)
self.assertEqual(task_type, task.type)
@ -335,8 +337,8 @@ class TestTaskFactory(test_utils.BaseTestCase):
self.assertIsNone(task.expires_at)
self.assertEqual(owner, task.owner)
self.assertEqual(task_input, task.task_input)
self.assertEqual(u'', task.message)
self.assertIsNone(task.result)
self.assertEqual('test_message', task.message)
self.assertEqual('test_result', task.result)
def test_new_task_invalid_type(self):
task_type = 'blah'