From 385ffab06f1657d10a8a7284bb83945d236bd6d7 Mon Sep 17 00:00:00 2001 From: Pankaj Mishra Date: Thu, 7 Apr 2016 15:56:22 +0530 Subject: [PATCH] Modified message of exception and log Metadata tag names are case insensitive, that confuses the user. So we added additional information about metadata tag duplication to clarify the point. Change-Id: Ib58a9d0b9cc95a831981de0cc19456f0c6713dbb Closes-Bug: #1535231 --- glance/common/exception.py | 4 +++- glance/db/sqlalchemy/metadef_api/tag.py | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/glance/common/exception.py b/glance/common/exception.py index b1255bd4f8..1313b7a961 100644 --- a/glance/common/exception.py +++ b/glance/common/exception.py @@ -397,7 +397,9 @@ class MetadefDuplicateResourceTypeAssociation(Duplicate): class MetadefDuplicateTag(Duplicate): message = _("A metadata tag with name=%(name)s" - " already exists in namespace=%(namespace_name)s.") + " already exists in namespace=%(namespace_name)s." + " (Please note that metadata tag names are" + " case insensitive).") class MetadefForbidden(Forbidden): diff --git a/glance/db/sqlalchemy/metadef_api/tag.py b/glance/db/sqlalchemy/metadef_api/tag.py index 4ec5ff84fb..556ef7887f 100644 --- a/glance/db/sqlalchemy/metadef_api/tag.py +++ b/glance/db/sqlalchemy/metadef_api/tag.py @@ -100,7 +100,9 @@ def create(context, namespace_name, values, session): metadef_tag.save(session=session) except db_exc.DBDuplicateEntry: LOG.debug("A metadata tag name=%(name)s" - " in namespace=%(namespace_name)s already exists.", + " already exists in namespace=%(namespace_name)s." + " (Please note that metadata tag names are" + " case insensitive).", {'name': metadef_tag.name, 'namespace_name': namespace_name}) raise exc.MetadefDuplicateTag(