From 76abb227addf1ae44813527084d1ceb7f36af606 Mon Sep 17 00:00:00 2001 From: Cyril Roelandt Date: Thu, 21 Jul 2022 00:16:20 +0200 Subject: [PATCH] glance-manage: fix crash under Python3.11 In Python3.11, the argparse module became stricter. While the following code was fine in previous versions, it will now raise an argparse.ArgumentError because we added the same subparser twice: import argparse parser = argparse.ArgumentParser() subparsers = parser.add_subparsers(title='Commands') subparsers.add_parser('foo') subparsers.add_parser('foo') subparsers.add_parser('bar') parser.parse_args() This mistake was silently ignore in Python3.10, which explains why this was never an issue for glance-manage. Closes-Bug: #1982426 Change-Id: I3a88ab5d2e67a1553f03b0b8ba44efbef976ffb0 --- glance/cmd/manage.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glance/cmd/manage.py b/glance/cmd/manage.py index f42bccb715..15d67f52f7 100644 --- a/glance/cmd/manage.py +++ b/glance/cmd/manage.py @@ -504,7 +504,7 @@ def add_command_parsers(subparsers): parser.add_argument('action_args', nargs='*') - add_legacy_command_parsers(command_object, subparsers) + add_legacy_command_parsers(command_object, subparsers) command_opt = cfg.SubCommandOpt('command',